src: fix build break for !NODE_USE_V8_PLATFORM

kunalspathak · kunalspathak · commit a606f84deafd · 2016-08-17T14:14:03.000-07:00
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM`. I have submitted PR nodejs/node#8114 to fix this in node repo. PR-URL: nodejs#108 Reviewed-By: Sandeep Agarwal <agarwal.sandeep@microsoft.com>
diff --git a/src/node.cc b/src/node.cc
@@ -220,8 +220,9 @@ static struct {
   void Initialize(int thread_pool_size) {}
   void PumpMessageLoop(Isolate* isolate) {}
   void Dispose() {}
-  void StartInspector(Environment *env, int port, bool wait) {
+  bool StartInspector(Environment *env, int port, bool wait) {
     env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0");
+    return false;  // make compiler happy
   }
 #endif  // !NODE_USE_V8_PLATFORM
 } v8_platform;
