Fixes OpenFeign#462

maximdim · adriancole · commit 0dfd7ea72091 · 2016-11-08T10:37:56.000-08:00
diff --git a/core/src/main/java/feign/Logger.java b/core/src/main/java/feign/Logger.java
@@ -81,7 +81,8 @@ protected Response logAndRebufferResponse(
         response.reason() != null && logLevel.compareTo(Level.NONE) > 0
             ? " " + response.reason()
             : "";
-    log(configKey, "<--- HTTP/1.1 %s%s (%sms)", response.status(), reason, elapsedTime);
+    int status = response.status();
+    log(configKey, "<--- HTTP/1.1 %s%s (%sms)", status, reason, elapsedTime);
     if (logLevel.ordinal() >= Level.HEADERS.ordinal()) {
 
       for (String field : response.headers().keySet()) {
@@ -91,7 +92,9 @@ protected Response logAndRebufferResponse(
       }
 
       int bodyLength = 0;
-      if (response.body() != null) {
+      if (response.body() != null && !(status == 204 || status == 205)) {
+        // HTTP 204 No Content "...response MUST NOT include a message-body"
+        // HTTP 205 Reset Content "...response MUST NOT include an entity"
         if (logLevel.ordinal() >= Level.FULL.ordinal()) {
           log(configKey, ""); // CRLF
         }
