Don't ignore synchronous errors when calling Node

SteveSandersonMS · SteveSandersonMS · commit 80575a092e8e · 2015-12-14T13:16:39.000Z
diff --git a/Microsoft.AspNet.AngularServices/Content/Node/angular-rendering.js b/Microsoft.AspNet.AngularServices/Content/Node/angular-rendering.js
@@ -31,17 +31,21 @@ function findAngularComponent(options) {
 
 module.exports = {
     renderToString: function(callback, options) {
-        var component = findAngularComponent(options);
-        var serverBindings = [
-            ngRouter.ROUTER_BINDINGS,
-            ngUniversal.HTTP_PROVIDERS,
-            ng.provide(ngUniversal.BASE_URL, { useValue: options.requestUrl }),
-            ngUniversal.SERVER_LOCATION_PROVIDERS
-        ];
+        try {
+            var component = findAngularComponent(options);
+            var serverBindings = [
+                ngRouter.ROUTER_BINDINGS,
+                ngUniversal.HTTP_PROVIDERS,
+                ng.provide(ngUniversal.BASE_URL, { useValue: options.requestUrl }),
+                ngUniversal.SERVER_LOCATION_PROVIDERS
+            ];
 
-        return ngUniversal.renderToString(component, serverBindings).then(
-            function(successValue) { callback(null, successValue); },
-            function(errorValue) { callback(errorValue); }
-        );
+            return ngUniversal.renderToString(component, serverBindings).then(
+                function(successValue) { callback(null, successValue); },
+                function(errorValue) { callback(errorValue); }
+            );
+        } catch (synchronousException) {
+            callback(synchronousException);
+        }
     }
 };
diff --git a/Microsoft.AspNet.NodeServices/Content/Node/entrypoint-http.js b/Microsoft.AspNet.NodeServices/Content/Node/entrypoint-http.js
@@ -39,7 +39,11 @@ var server = http.createServer(function(req, res) {
             }
         };
         
-        func.apply(null, [callback].concat(bodyJson.args));        
+        try {
+            func.apply(null, [callback].concat(bodyJson.args));
+        } catch (synchronousException) {
+            callback(synchronousException, null);
+        }     
     });
 });
 
diff --git a/Microsoft.AspNet.NodeServices/HostingModels/HttpNodeInstance.cs b/Microsoft.AspNet.NodeServices/HostingModels/HttpNodeInstance.cs
@@ -32,8 +32,8 @@ public override async Task<T> Invoke<T>(NodeInvocationInfo invocationInfo) {
                 var response = await client.PostAsync("http://localhost:" + this._portNumber, payload);
                 var responseString = await response.Content.ReadAsStringAsync();
                 
-                if (response.StatusCode != HttpStatusCode.OK) {
-                    throw new Exception("Node module responded with error: " + responseString);   
+                if (!response.IsSuccessStatusCode) {
+                    throw new Exception("Call to Node module failed with error: " + responseString);
                 }
                 
                 var responseIsJson = response.Content.Headers.ContentType.MediaType == "application/json";
diff --git a/Microsoft.AspNet.ReactServices/Content/Node/react-rendering.js b/Microsoft.AspNet.ReactServices/Content/Node/react-rendering.js
@@ -45,10 +45,14 @@ function loadViaBabel(module, filename) {
 
 module.exports = {
     renderToString: function(callback, options) {
-        var component = findReactComponent(options);
-        var history = createMemoryHistory(options.requestUrl);
-        var reactElement = React.createElement(component, { history: history });
-        var html = ReactDOMServer.renderToString(reactElement);
-        callback(null, html);
+        try {
+            var component = findReactComponent(options);
+            var history = createMemoryHistory(options.requestUrl);
+            var reactElement = React.createElement(component, { history: history });
+            var html = ReactDOMServer.renderToString(reactElement);
+            callback(null, html);
+        } catch (synchronousException) {
+            callback(synchronousException);
+        }
     }
 };

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,8 @@ public override async Task<T> Invoke<T>(NodeInvocationInfo invocationInfo) {`
`32`	`32`	`var response = await client.PostAsync("http://localhost:" + this._portNumber, payload);`
`33`	`33`	`var responseString = await response.Content.ReadAsStringAsync();`
`34`	`34`
`35`		`- if (response.StatusCode != HttpStatusCode.OK) {`
`36`		`- throw new Exception("Node module responded with error: " + responseString);`
	`35`	`+ if (!response.IsSuccessStatusCode) {`
	`36`	`+ throw new Exception("Call to Node module failed with error: " + responseString);`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`var responseIsJson = response.Content.Headers.ContentType.MediaType == "application/json";`