use static drain buffer to avoid needless garbage

robaho · robaho · commit e67636bc793c · 2024-07-04T07:47:58.000-05:00
diff --git a/src/main/java/robaho/net/httpserver/LeftOverInputStream.java b/src/main/java/robaho/net/httpserver/LeftOverInputStream.java
@@ -89,20 +89,21 @@ public synchronized int read(byte[] b, int off, int len) throws IOException {
         return readImpl(b, off, len);
     }
 
+    // ok to concurrently share this since the data isn't used
+    private static final byte[] drainBuffer = new byte[2048];
     /**
      * read and discard up to l bytes or "eof" occurs,
      * (whichever is first). Then return true if the stream
      * is at eof (ie. all bytes were read) or false if not
      * (still bytes to be read)
      */
     public boolean drain(long l) throws IOException {
-        int bufSize = 2048;
-        byte[] db = new byte[bufSize];
+
         while (l > 0) {
             if (server.isFinishing()) {
                 break;
             }
-            long len = readImpl(db, 0, bufSize);
+            long len = readImpl(drainBuffer, 0, drainBuffer.length);
             if (len == -1) {
                 eof = true;
                 return true;
