optimize logging

robaho · robaho · commit 893da735ba4f · 2024-06-23T11:36:19.000-05:00
diff --git a/src/main/java/robaho/net/httpserver/ExchangeImpl.java b/src/main/java/robaho/net/httpserver/ExchangeImpl.java
@@ -235,7 +235,7 @@ public void sendResponseHeaders(int rCode, long contentLen)
 
         /* check for response type that is not allowed to send a body */
         if (rCode == 101) {
-            logger.log(Level.INFO, "switching protocols");
+            logger.log(Level.DEBUG, () -> "switching protocols");
 
             if (contentLen != 0) {
                 String msg = "sendResponseHeaders: rCode = " + rCode
@@ -310,7 +310,9 @@ else if (http10) {
         write(rspHdrs, ros);
         this.rspContentLen = contentLen;
         sentHeaders = true;
-        logger.log(Level.TRACE, "Sent headers: noContentToSend=" + noContentToSend);
+        if(logger.isLoggable(Level.TRACE)) {
+            logger.log(Level.TRACE, "Sent headers: noContentToSend=" + noContentToSend);
+        }
         if(contentLen==0) {
             ros.flush();
         }   
diff --git a/src/main/java/robaho/net/httpserver/ServerImpl.java b/src/main/java/robaho/net/httpserver/ServerImpl.java
@@ -362,7 +362,7 @@ private void closeConnection(HttpConnection conn) {
 
     /* per exchange task */
     class Exchange implements Runnable {
-        HttpConnection connection;
+        final HttpConnection connection;
         InputStream rawin;
         OutputStream rawout;
         String protocol;
@@ -379,7 +379,7 @@ public void run() {
             this.rawin = connection.getInputStream();
             this.rawout = connection.getOutputStream();
 
-            logger.log(Level.TRACE, "exchange started "+connection.toString());
+            logger.log(Level.TRACE, () -> "exchange started "+connection.toString());
 
             while (true) {
                 try {
@@ -412,7 +412,7 @@ public void run() {
                     throw t;
                 }
             }
-            logger.log(Level.TRACE, "exchange finished "+connection.toString());
+            logger.log(Level.TRACE, () -> "exchange finished "+connection.toString());
         }
 
         private void runPerRequest() throws IOException {
@@ -422,7 +422,7 @@ private void runPerRequest() throws IOException {
 
             connection.inRequest = false;
             Request req = new Request(rawin, rawout);
-            String requestLine = req.requestLine();
+            final String requestLine = req.requestLine();
             connection.inRequest = true;
 
             if (requestLine == null) {
@@ -431,7 +431,7 @@ private void runPerRequest() throws IOException {
                 closeConnection(connection);
                 return;
             }
-            logger.log(Level.DEBUG, "Exchange request line: {0}", requestLine);
+            logger.log(Level.DEBUG, () -> "Exchange request line: "+ requestLine);
             int space = requestLine.indexOf(' ');
             if (space == -1) {
                 reject(Code.HTTP_BAD_REQUEST,
@@ -504,7 +504,7 @@ private void runPerRequest() throws IOException {
                     }
                 }
             }
-            logger.log(Level.INFO,"protocol "+protocol+" uri "+uri+" headers "+headers);
+            logger.log(Level.TRACE,() -> "protocol "+protocol+" uri "+uri+" headers "+headers);
             String uriPath = Optional.ofNullable(uri.getPath()).orElse("/");
             ctx = contexts.findContext(protocol, uriPath);
             if (ctx == null) {
