Make it easy to provide a custom ObjectMapper (docker-java#1637)

bsideup · web-flow · commit a53119420bd8 · 2021-05-27T21:49:24.000+02:00
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/DockerClientConfig.java b/docker-java-core/src/main/java/com/github/dockerjava/core/DockerClientConfig.java
@@ -19,6 +19,10 @@
  */
 public interface DockerClientConfig {
 
+    static ObjectMapper getDefaultObjectMapper() {
+        return DefaultObjectMapperHolder.INSTANCE.getObjectMapper().copy();
+    }
+
     URI getDockerHost();
 
     RemoteApiVersion getApiVersion();
@@ -41,7 +45,7 @@ public interface DockerClientConfig {
     SSLConfig getSSLConfig();
 
     default ObjectMapper getObjectMapper() {
-        return DefaultObjectMapperHolder.INSTANCE.getObjectMapper().copy();
+        return getDefaultObjectMapper();
     }
 }
 
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/DockerClientConfigDelegate.java b/docker-java-core/src/main/java/com/github/dockerjava/core/DockerClientConfigDelegate.java
@@ -0,0 +1,57 @@
+package com.github.dockerjava.core;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.github.dockerjava.api.model.AuthConfig;
+import com.github.dockerjava.api.model.AuthConfigurations;
+
+import java.net.URI;
+
+@SuppressWarnings("unused")
+public class DockerClientConfigDelegate implements DockerClientConfig {
+
+    final DockerClientConfig original;
+
+    public DockerClientConfigDelegate(DockerClientConfig original) {
+        this.original = original;
+    }
+
+    public URI getDockerHost() {
+        return original.getDockerHost();
+    }
+
+    public RemoteApiVersion getApiVersion() {
+        return original.getApiVersion();
+    }
+
+    public String getRegistryUsername() {
+        return original.getRegistryUsername();
+    }
+
+    public String getRegistryPassword() {
+        return original.getRegistryPassword();
+    }
+
+    public String getRegistryEmail() {
+        return original.getRegistryEmail();
+    }
+
+    public String getRegistryUrl() {
+        return original.getRegistryUrl();
+    }
+
+    public AuthConfig effectiveAuthConfig(String imageName) {
+        return original.effectiveAuthConfig(imageName);
+    }
+
+    public AuthConfigurations getAuthConfigurations() {
+        return original.getAuthConfigurations();
+    }
+
+    public SSLConfig getSSLConfig() {
+        return original.getSSLConfig();
+    }
+
+    public ObjectMapper getObjectMapper() {
+        return original.getObjectMapper();
+    }
+}
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/async/JsonStreamProcessor.java b/docker-java-core/src/main/java/com/github/dockerjava/core/async/JsonStreamProcessor.java
@@ -13,7 +13,7 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.github.dockerjava.api.async.ResultCallback;
-import com.github.dockerjava.core.DefaultDockerClientConfig;
+import com.github.dockerjava.core.DockerClientConfig;
 
 /**
  *
@@ -33,7 +33,7 @@ public class JsonStreamProcessor<T> implements ResponseStreamProcessor<T> {
     @Deprecated
     public JsonStreamProcessor(Class<T> clazz) {
         this(
-                DefaultDockerClientConfig.createDefaultConfigBuilder().build().getObjectMapper(),
+                DockerClientConfig.getDefaultObjectMapper(),
                 new TypeReference<T>() {
                 }
         );
diff --git a/docker-java-transport-netty/src/main/java/com/github/dockerjava/netty/NettyInvocationBuilder.java b/docker-java-transport-netty/src/main/java/com/github/dockerjava/netty/NettyInvocationBuilder.java
@@ -6,7 +6,7 @@
 import com.github.dockerjava.api.async.ResultCallback;
 import com.github.dockerjava.api.exception.DockerClientException;
 import com.github.dockerjava.api.model.Frame;
-import com.github.dockerjava.core.DefaultDockerClientConfig;
+import com.github.dockerjava.core.DockerClientConfig;
 import com.github.dockerjava.core.InvocationBuilder;
 import com.github.dockerjava.core.async.ResultCallbackTemplate;
 import com.github.dockerjava.netty.handler.FramedResponseStreamHandler;
@@ -85,7 +85,7 @@ public void onNext(Void object) {
     @Deprecated
     public NettyInvocationBuilder(ChannelProvider channelProvider, String resource) {
         this(
-                DefaultDockerClientConfig.createDefaultConfigBuilder().build().getObjectMapper(),
+                DockerClientConfig.getDefaultObjectMapper(),
                 channelProvider,
                 resource
         );
diff --git a/docker-java-transport-netty/src/main/java/com/github/dockerjava/netty/NettyWebTarget.java b/docker-java-transport-netty/src/main/java/com/github/dockerjava/netty/NettyWebTarget.java
@@ -13,7 +13,7 @@
 import java.util.Set;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
-import com.github.dockerjava.core.DefaultDockerClientConfig;
+import com.github.dockerjava.core.DockerClientConfig;
 import com.github.dockerjava.core.WebTarget;
 import com.google.common.collect.ImmutableSet;
 import io.netty.handler.codec.http.HttpConstants;
@@ -50,7 +50,7 @@ public class NettyWebTarget implements WebTarget {
     @Deprecated
     public NettyWebTarget(ChannelProvider channelProvider, String host) {
         this(
-                DefaultDockerClientConfig.createDefaultConfigBuilder().build().getObjectMapper(),
+                DockerClientConfig.getDefaultObjectMapper(),
                 channelProvider,
                 host,
                 ImmutableList.of(),
diff --git a/docker-java-transport-netty/src/main/java/com/github/dockerjava/netty/handler/JsonRequestHandler.java b/docker-java-transport-netty/src/main/java/com/github/dockerjava/netty/handler/JsonRequestHandler.java
@@ -1,12 +1,11 @@
 package com.github.dockerjava.netty.handler;
 
-import com.github.dockerjava.core.DefaultDockerClientConfig;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.github.dockerjava.core.DockerClientConfig;
 import io.netty.buffer.ByteBuf;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.handler.codec.MessageToByteEncoder;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-
 /**
  * Handler that encodes an outgoing object to JSON.
  *
@@ -17,7 +16,7 @@
 @Deprecated
 public class JsonRequestHandler extends MessageToByteEncoder<Object> {
 
-    private ObjectMapper mapper = DefaultDockerClientConfig.createDefaultConfigBuilder().build().getObjectMapper();
+    private ObjectMapper mapper = DockerClientConfig.getDefaultObjectMapper();
 
     @Override
     protected void encode(ChannelHandlerContext ctx, Object msg, ByteBuf out) throws Exception {
diff --git a/docker-java-transport-netty/src/main/java/com/github/dockerjava/netty/handler/JsonResponseCallbackHandler.java b/docker-java-transport-netty/src/main/java/com/github/dockerjava/netty/handler/JsonResponseCallbackHandler.java
@@ -1,6 +1,6 @@
 package com.github.dockerjava.netty.handler;
 
-import com.github.dockerjava.core.DefaultDockerClientConfig;
+import com.github.dockerjava.core.DockerClientConfig;
 import io.netty.buffer.ByteBuf;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.SimpleChannelInboundHandler;
@@ -25,7 +25,7 @@ public class JsonResponseCallbackHandler<T> extends SimpleChannelInboundHandler<
     @Deprecated
     public JsonResponseCallbackHandler(TypeReference<T> typeReference, ResultCallback<T> callback) {
         this(
-                DefaultDockerClientConfig.createDefaultConfigBuilder().build().getObjectMapper(),
+                DockerClientConfig.getDefaultObjectMapper(),
                 typeReference,
                 callback
         );
diff --git a/docker-java/src/test/java/com/github/dockerjava/test/serdes/JSONTestHelper.java b/docker-java/src/test/java/com/github/dockerjava/test/serdes/JSONTestHelper.java
@@ -17,7 +17,7 @@
 
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import com.github.dockerjava.core.DefaultDockerClientConfig;
+import com.github.dockerjava.core.DockerClientConfig;
 import org.apache.commons.io.IOUtils;
 
 import java.io.IOException;
@@ -37,7 +37,7 @@ public class JSONTestHelper {
 
     static {
         try {
-            MAPPER = DefaultDockerClientConfig.createDefaultConfigBuilder().build().getObjectMapper();
+            MAPPER = DockerClientConfig.getDefaultObjectMapper();
         } catch (Throwable e) {
             e.printStackTrace();
             throw e;
