Skip to content

Commit 7bb173d

Browse files
committed
Revert "Retry connection failure while instantiating connection provider (feast-dev#144)"
This reverts commit fcb80a0. Signed-off-by: khorshuheng <khor.heng@gojek.com>
1 parent 2968302 commit 7bb173d

3 files changed

Lines changed: 1 addition & 120 deletions

File tree

spark/ingestion/src/main/scala/feast/ingestion/errorhanders/RetryStrategy.scala

Lines changed: 0 additions & 37 deletions
This file was deleted.

spark/ingestion/src/main/scala/feast/ingestion/stores/redis/ClusterPipelineProvider.scala

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,10 @@
1616
*/
1717
package feast.ingestion.stores.redis
1818

19-
import feast.ingestion.errorhanders.RetryStrategy
20-
import redis.clients.jedis.exceptions.JedisClusterOperationException
2119
import redis.clients.jedis.{ClusterPipeline, DefaultJedisClientConfig, HostAndPort}
2220
import redis.clients.jedis.providers.ClusterConnectionProvider
2321

2422
import scala.collection.JavaConverters._
25-
import scala.concurrent.duration.DurationInt
26-
import scala.util.{Failure, Success, Try}
2723

2824
/**
2925
* Provide pipeline for Redis cluster.
@@ -35,17 +31,7 @@ case class ClusterPipelineProvider(endpoint: RedisEndpoint) extends PipelineProv
3531
.builder()
3632
.password(endpoint.password)
3733
.build()
38-
val MAX_RECONNECTION_ATTEMPT = 2
39-
val RETRY_INTERVAL = 2.seconds
40-
val provider = RetryStrategy.fixedBackOff(RETRY_INTERVAL, MAX_RECONNECTION_ATTEMPT)(getProvider)
41-
42-
def getProvider: Either[JedisClusterOperationException, ClusterConnectionProvider] = {
43-
Try { new ClusterConnectionProvider(nodes, DEFAULT_CLIENT_CONFIG) } match {
44-
case Success(provider) => Right(provider)
45-
case Failure(e: JedisClusterOperationException) => Left(e)
46-
case Failure(e) => throw e
47-
}
48-
}
34+
val provider = new ClusterConnectionProvider(nodes, DEFAULT_CLIENT_CONFIG)
4935

5036
/**
5137
* @return a cluster pipeline

spark/ingestion/src/test/scala/feast/ingestion/errorhandlers/RetryStrategySpec.scala

Lines changed: 0 additions & 68 deletions
This file was deleted.

0 commit comments

Comments
 (0)