fix(windows): deletion test using tsf interface#15826
Open
Conversation
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes with #15813 it is just updating a sample TIP to enable reproduciable steps without a full Keyman and keyboard install. Here is the Microsoft Feedback Hub link
Notepad in Windows 11 removes extra unicode char when using the
ITfRange interface - Text Services Framework.This behaviour has so far only been observed with Notepad on Windows 11 other complaint TSF apps I have tested do not behave this way. I have tested a other that use the TSF such as lvirus Text Editor, Word etc.
Steps to reproduce
The project is in
keyman\app\windows\src\support\tsf-tip-standalone-testif you wish to checkout and build.I have attached the output a zip TextService-Step06-3_x64.zip that contains output dll.
regsvr32 TextService-Step06-3_x64.dllIcelandic Sample Text Servicewhich can be selected from the language bar.Icelandic Sample Text Servicefórwhich is U+0066 U+006f U+0301 U+0072rExpected is the just the diacritic is deleted and the cursor is to the right of the
o. LeavingforIf you open Word or another TSF compliant application and run the same steps you will observe the expected behaviour.
Note I logged the value of
outnafter callingShiftStartto see if Notepad was reporting2characters. However, the value was1. This matched the value set in Word.if(tfSelection.range->ShiftStart(ec, -n, &outn, NULL) != S_OK)