refactor(web): extract token-search result duplicate-filtering method 🚂#15816
Open
jahorton wants to merge 8 commits intochange/web/return-search-token-mappingfrom
Open
refactor(web): extract token-search result duplicate-filtering method 🚂#15816jahorton wants to merge 8 commits intochange/web/return-search-token-mappingfrom
jahorton wants to merge 8 commits intochange/web/return-search-token-mappingfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This was referenced Apr 9, 2026
Build-bot: skip build:web Test-bot: skip
8666dcd to
b4b40bd
Compare
30bb779 to
3ae0e4c
Compare
…eb/extract-duplicate-result-filter
…refactor/web/extract-duplicate-result-filter-extended
ermshiperete
approved these changes
Apr 23, 2026
| } | ||
|
|
||
| protected buildEdgesForNodes(baseNodes: ReadonlyArray<SearchNode>) { | ||
| protected buildEdgesFromResults(priorResults: ReadonlyArray<TokenResultMapping>) { |
Contributor
There was a problem hiding this comment.
Suggested change
| protected buildEdgesFromResults(priorResults: ReadonlyArray<TokenResultMapping>) { | |
| protected buildEdgesFromResults(priorResults: ReadonlyArray<TokenResultMapping>): SearchNode[] { |
| let bestCorrectionCost: number; | ||
| const correctionPredictionMap: Record<string, Distribution<Suggestion>> = {}; | ||
| for await(const match of getBestMatches(searchModules, timer)) { | ||
| for await(const match of getBestMatches(searchModules, timer, initTokenResultFilterer())) { |
Contributor
There was a problem hiding this comment.
Suggested change
| for await(const match of getBestMatches(searchModules, timer, initTokenResultFilterer())) { | |
| for await(const match of getBestTokenMatches(searchModules, timer)) { |
Comment on lines
+625
to
626
| filter(result); | ||
| return result; |
Contributor
There was a problem hiding this comment.
Is this correct? We don't do anything with the return value of filter, so this calls seems a bit pointless here, but I'm probably missing something.
Suggested change
| filter(result); | |
| return result; | |
| return filter(result) ? result : null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip build:web
Test-bot: skip