change(web): return token-correction mapping from search-oriented methods 🚂#15815
Open
jahorton wants to merge 5 commits intorefactor/web/move-and-rename-SearchResultfrom
Open
change(web): return token-correction mapping from search-oriented methods 🚂#15815jahorton wants to merge 5 commits intorefactor/web/move-and-rename-SearchResultfrom
jahorton wants to merge 5 commits intorefactor/web/move-and-rename-SearchResultfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This was referenced Apr 9, 2026
…hods Build-bot: skip build:web Test-bot: skip
c92585c to
77b8af2
Compare
8666dcd to
b4b40bd
Compare
After using devin.ai to check some of my PRs, it caught something on #15817 that I was able to trace back to some decisions already in place for `TokenResultMapping`. It appears best to simplify the type and its relation to spaceId-tagging now to simplify it, to prevent the bug, and to hopefully prevent re-implementing the bug in the future. I did consider constructing new instances of SearchNode, just with the changed spaceId... but that may be prone to causing memory churn that can be avoided by just letting spaceId be public. Build-bot: skip build:web Test-bot: skip
…b/return-search-token-mapping
…b/return-search-token-mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip build:web
Test-bot: skip