keyjote
diff --git a/‎README.md‎
Lines changed: 4 additions & 0 deletions b/‎README.md‎
Lines changed: 4 additions & 0 deletions
diff --git a/‎regression/reg.pl‎
Lines changed: 1 addition & 1 deletion b/‎regression/reg.pl‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎sqlserver2pgsql.pl‎
Lines changed: 20 additions & 2 deletions b/‎sqlserver2pgsql.pl‎
Lines changed: 20 additions & 2 deletions
@@ -92,6 +92,10 @@ there is a default dbo=>public remapping, that can be cancelled with -nr. Use do
 -num : Converts numeric (xxx,0) to the appropriate smallint, integer or bigint. It won't keep the constraint on
 the size of the scale of the numeric
 
+-validate_constraints=yes/after/no: for foreign keys, if yes: foreign keys are created as valid in the after script (default)
+                                                      if no: they are created as not valid (enforced only for new rows)
+                                                      if after: they are created as not valid, but the statements to validate them are put in the unsure file
+
 If you want to also import data:
 
 > ./sqlserver2pgsql.pl -b before.sql -a after.sql -u unsure.sql -k kettledir \ 
 
@@ -7,7 +7,7 @@
 
 foreach my $file (<*.sql>)
 {
-	my @options_to_try=('-i','-nr','-num', '-keep_identifier_case');
+	my @options_to_try=('-i','-nr','-num', '-keep_identifier_case', '-validate_constraints=after');
 	my @all_combinations=('');
 	foreach my $option (@options_to_try)
 	{
 
@@ -41,6 +41,7 @@
 our $after_file;
 our $unsure_file;
 our $keep_identifier_case;
+our $validate_constraints='yes';
 
 my $template
     ; # These two variables are loaded in the BEGIN block at the end of this file (they are very big
@@ -77,7 +78,8 @@ sub parse_conf_file
                       'no relabel dbo'           => 'norelabel_dbo',
                       'convert numeric to int'   => 'convert_numeric_to_int',
                       'relabel schemas'          => 'relabel_schemas',
-                      'keep identifier case'                => 'keep_identifier_case',
+                      'keep identifier case'     => 'keep_identifier_case',
+                      'validate constraints'     => 'validate_constraints',
                      );
 
     # Open the conf file or die
@@ -1823,8 +1825,18 @@ sub generate_schema
                     {
                         $consdef .= " ON UPDATE CASCADE";
                     }
+                    # We need a name on the constraint to be able to validate it later. Maybe it would be better to generate one
+                    # FIXME: we'll see later if a generator is needed (probably)
+                    if ($constraint->{TYPE} eq 'FK' and ($validate_constraints =~ /^after|no$/) and defined($constraint->{NAME}))
+                    {
+                        $consdef .= " NOT VALID";
+                    }
                     $consdef .= ";\n";
                     print AFTER $consdef;
+                    if ($constraint->{TYPE} eq 'FK' and $validate_constraints eq 'after' and defined $constraint->{NAME})
+                    {
+                        print UNSURE "ALTER TABLE " . format_identifier($schema) . '.' . format_identifier($table) . " VALIDATE CONSTRAINT " . format_identifier($constraint->{NAME}) . ";\n";
+                    }
                 }
                 elsif ($constraint->{TYPE} eq 'CHECK')
                 {
@@ -2075,7 +2087,8 @@ sub resolve_name_conflicts
                          "nr"     => \$norelabel_dbo,
                          "num"    => \$convert_numeric_to_int,
                          "relabel_schemas=s" => \$relabel_schemas,
-                         "keep_identifier_case" =>\$keep_identifier_case,);
+                         "keep_identifier_case" =>\$keep_identifier_case,
+                         "validate_constraints=s" =>\$validate_constraints,);
 
 # We don't understand command line or have been asked for usage
 if (not $options or $help)
@@ -2101,6 +2114,11 @@ sub resolve_name_conflicts
     exit 1;
 }
 
+if ($validate_constraints !~ '^(yes|after|no)$')
+{
+    die "validate_constraints should be yes, after or no (default yes)\n";
+}
+
 # We have been asked for kettle, but the compulsory parameters are not there
 if ($kettle
     and (   not $sd
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`foreach my $file (<*.sql>)`
`9`	`9`	`{`
`10`		`- my @options_to_try=('-i','-nr','-num', '-keep_identifier_case');`
	`10`	`+ my @options_to_try=('-i','-nr','-num', '-keep_identifier_case', '-validate_constraints=after');`
`11`	`11`	`my @all_combinations=('');`
`12`	`12`	`foreach my $option (@options_to_try)`
`13`	`13`	`{`