Skip to content

Commit b1cce04

Browse files
committed
build: rename strict_aliasing to node_no_strict_aliasing
Make the variable naming consistent with the other strict aliasing var, v8_no_strict_aliasing.
1 parent b731c96 commit b1cce04

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

common.gypi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
'variables': {
3-
'strict_aliasing%': 'false', # turn on/off -fstrict-aliasing
3+
'node_no_strict_aliasing%': 0, # turn off -fstrict-aliasing
44
'visibility%': 'hidden', # V8's visibility setting
55
'target_arch%': 'ia32', # set v8's target architecture
66
'host_arch%': 'ia32', # set v8's host architecture
@@ -52,7 +52,7 @@
5252
# pull in V8's postmortem metadata
5353
'ldflags': [ '-Wl,-z,allextract' ]
5454
}],
55-
['strict_aliasing!="true"', {
55+
['node_no_strict_aliasing==1', {
5656
'cflags': [ '-fno-strict-aliasing' ],
5757
}],
5858
],

configure

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -287,9 +287,9 @@ def configure_node(o):
287287
# turn off strict aliasing if gcc < 4.6.0 unless it's llvm-gcc
288288
# see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45883
289289
# see http://code.google.com/p/v8/issues/detail?id=884
290-
strict_aliasing = is_clang or cc_version >= (4,6,0)
291-
o['variables']['strict_aliasing'] = b(strict_aliasing)
292-
o['variables']['v8_no_strict_aliasing'] = b(not strict_aliasing)
290+
no_strict_aliasing = int(not(is_clang or cc_version >= (4,6,0)))
291+
o['variables']['v8_no_strict_aliasing'] = no_strict_aliasing
292+
o['variables']['node_no_strict_aliasing'] = no_strict_aliasing
293293

294294
# clang has always supported -fvisibility=hidden, right?
295295
if not is_clang and cc_version < (4,0,0):

0 commit comments

Comments
 (0)