fix warnings generated because of connection leak

Ali Rizwan · Ali Rizwan · commit fffd0343ba59 · 2020-12-22T17:50:23.000+01:00
body should be closed ref: square/okhttp#2311 Currently warnings are generated from okhttp: ``` com.spotify.githubclient.shade.okhttp3.internal.platform.Platform log WARNING: A connection to https://ghe.spotify.net/ was leaked. Did you forget to close a response body? To see where this was allocated, set the OkHttpClient logger level to FINE: Logger.getLogger(OkHttpClient.class.getName()).setLevel(Level.FINE); ```
diff --git a/src/main/java/com/spotify/github/v3/clients/GitHubClient.java b/src/main/java/com/spotify/github/v3/clients/GitHubClient.java
@@ -54,12 +54,8 @@
 import java.util.function.Consumer;
 import javax.ws.rs.core.HttpHeaders;
 import javax.ws.rs.core.MediaType;
-import okhttp3.Call;
-import okhttp3.Callback;
-import okhttp3.OkHttpClient;
-import okhttp3.Request;
-import okhttp3.RequestBody;
-import okhttp3.Response;
+
+import okhttp3.*;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -232,8 +228,8 @@ public static GitHubClient scopeForInstallationId(
   }
 
   static String responseBodyUnchecked(final Response response) {
-    try {
-      return response.body().string();
+    try (ResponseBody body = response.body()) {
+      return body.string();
     } catch (IOException e) {
       throw new UncheckedIOException("Failed getting response body for: " + response, e);
     }
@@ -651,6 +647,10 @@ public void onResponse(final Call call, final Response response) {
                           future.completeExceptionally(mapException(res, request));
                         } catch (final Throwable e) {
                           future.completeExceptionally(e);
+                        } finally {
+                          if (res.body() != null) {
+                            res.body().close();
+                          }
                         }
                       } else {
                         future.complete(res);
