Properly mark optional parameters to functions.

John Vilk · John Vilk · commit f687656d42f1 · 2016-02-10T11:41:07.000-05:00
diff --git a/generate/lib/write_ts_declarations.js b/generate/lib/write_ts_declarations.js
@@ -148,7 +148,7 @@ var writeTsDecls = function(apiData, path) {
           jsDoc += param.description.replace(/\n/g, '\n    ') + "\n";
         }
         // Make each param type a union type if multiple types.
-        return paramName + ": " + (param.types.map(function(type) { return getType(type); }).join(" | "));
+        return paramName + (param.optional ? "?" : "") + ": " + (param.types.map(function(type) { return getType(type); }).join(" | "));
       }).join(', ') + "): ";
 
     var returnType = fcn.return ? getType(fcn.return.type) : "void";

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ var writeTsDecls = function(apiData, path) {`
`148`	`148`	`jsDoc += param.description.replace(/\n/g, '\n ') + "\n";`
`149`	`149`	`}`
`150`	`150`	`// Make each param type a union type if multiple types.`
`151`		`- return paramName + ": " + (param.types.map(function(type) { return getType(type); }).join(" \| "));`
	`151`	`+ return paramName + (param.optional ? "?" : "") + ": " + (param.types.map(function(type) { return getType(type); }).join(" \| "));`
`152`	`152`	`}).join(', ') + "): ";`
`153`	`153`
`154`	`154`	`var returnType = fcn.return ? getType(fcn.return.type) : "void";`