when fetching object store properties use lower()

Steve Martinelli · Steve Martinelli · commit 74a6a81ae9d2 · 2015-12-14T12:23:44.000-05:00
sometimes properties within object store concepts are stored with
mixed case depending on the client used to store said properties.

when retrieving properties to 'show' the user, always call lower()
on the property in question when comparing it to the reserved
values of the swift API.

Change-Id: I97ffc715788ca3cd021413124b6945a399465c99
Closes-Bug: 1525805
diff --git a/openstackclient/api/object_store_v1.py b/openstackclient/api/object_store_v1.py
@@ -570,6 +570,6 @@ def _get_properties(self, headers, header_tag):
         # OSC commands
         properties = {}
         for k, v in six.iteritems(headers):
-            if k.startswith(header_tag):
+            if k.lower().startswith(header_tag):
                 properties[k[len(header_tag):]] = v
         return properties
diff --git a/openstackclient/tests/api/test_object_store_v1.py b/openstackclient/tests/api/test_object_store_v1.py
@@ -157,6 +157,7 @@ def test_container_show(self):
             'container': 'qaz',
             'object_count': '1',
             'bytes_used': '577',
+            'properties': {'Owner': FAKE_ACCOUNT},
         }
         self.requests_mock.register_uri(
             'HEAD',
@@ -309,6 +310,7 @@ def test_object_show(self):
             'etag': 'qaz',
             'x-container-meta-owner': FAKE_ACCOUNT,
             'x-object-meta-wife': 'Wilma',
+            'x-object-meta-Husband': 'fred',
             'x-tra-header': 'yabba-dabba-do',
         }
         resp = {
@@ -319,7 +321,8 @@ def test_object_show(self):
             'content-length': '577',
             'last-modified': '20130101',
             'etag': 'qaz',
-            'properties': {'wife': 'Wilma'},
+            'properties': {'wife': 'Wilma',
+                           'Husband': 'fred'},
         }
         self.requests_mock.register_uri(
             'HEAD',
diff --git a/releasenotes/notes/bug_1525805-122e6ce0c3cd4945.yaml b/releasenotes/notes/bug_1525805-122e6ce0c3cd4945.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Fix case sensitivity when showing object-store properties.
+    [Bug `1525805 <https://bugs.launchpad.net/bugs/1525805>`_]

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +fixes:
 +  - |
 +    Fix case sensitivity when showing object-store properties.
 +    [Bug `1525805 <https://bugs.launchpad.net/bugs/1525805>`_]