Skip to content

Commit f788e53

Browse files
committed
Merge pull request python-beaver#378 from josegonzalez/contributing
Fixups for CONTRIBUTING
2 parents b0a346c + 9f8bbc2 commit f788e53

2 files changed

Lines changed: 145 additions & 93 deletions

File tree

CONTRIBUTING.md

Lines changed: 145 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
1+
# Contributing to Python-Beaver
2+
3+
[Beaver](https://github.com/josegonzalez/python-beaver) and want to get involved?
4+
Thanks! There are plenty of ways you can help!
5+
6+
Please take a moment to review this document in order to make the contribution
7+
process easy and effective for everyone involved.
8+
9+
Following these guidelines helps to communicate that you respect the time of
10+
the developers managing and developing this open source project. In return,
11+
they should reciprocate that respect in addressing your issue or assessing
12+
patches and features.
13+
14+
## Using the issue tracker
15+
16+
The [issue tracker](https://github.com/josegonzalez/python-beaver/issues) is
17+
the preferred channel for [bug reports](#bugs), [features requests](#features)
18+
and [submitting pull requests](#pull-requests).
19+
20+
<a name="bugs"></a>
21+
## Bug reports
22+
23+
A bug is a _demonstrable problem_ that is caused by the code in the repository.
24+
Good bug reports are extremely helpful - thank you!
25+
26+
Guidelines for bug reports:
27+
28+
1. **Use the GitHub issue search** &mdash; check if the issue has already been
29+
reported.
30+
31+
2. **Check if the issue has been fixed** &mdash; try to reproduce it using the
32+
latest `master` branch in the repository.
33+
34+
3. **Reproduce the problem** &mdash; providing as much detail as possible so the
35+
bug can be identified and replicated locally.
36+
37+
A good bug report shouldn't leave others needing to chase you up for more
38+
information. Please try to be as detailed as possible in your report. What is
39+
your environment? What steps will reproduce the issue? What OS and Beaver
40+
versions were running when you experienced the outcome? What would you expect to
41+
be the outcome? All these details will help people to fix any potential bugs.
42+
43+
Example:
44+
45+
> Short and descriptive example bug report title
46+
>
47+
> A summary of the issue and the OS\application environment in which it occurs.
48+
> If suitable, include the steps required to reproduce the bug.
49+
>
50+
> 1. This is the first step
51+
> 2. This is the second step
52+
> 3. Further steps, etc.
53+
>
54+
> Config and (if applicable) log file examples in code tags, or via a [Gist](https://gist.github.com).
55+
>
56+
> Any other information you want to share that is relevant to the issue being
57+
> reported. This might include the lines of code that you have identified as
58+
> causing the bug, and potential solutions (and your opinions on their
59+
> merits).
60+
61+
62+
<a name="features"></a>
63+
## Feature requests
64+
65+
Feature requests are welcome. But take a moment to find out whether your idea
66+
fits with the scope and aims of the project. It's up to *you* to make a strong
67+
case to convince the project's developers of the merits of this feature. Please
68+
provide as much detail and context as possible.
69+
70+
71+
<a name="pull-requests"></a>
72+
## Pull requests
73+
74+
Good pull requests - patches, improvements, new features - are a fantastic
75+
help. They should remain focused in scope and avoid containing unrelated
76+
commits.
77+
78+
**Please ask first** before embarking on any significant pull request (e.g.
79+
implementing features, refactoring code, porting to a different language),
80+
otherwise you risk spending a lot of time working on something that the
81+
project's developers might not want to merge into the project.
82+
83+
Please adhere to the coding conventions used throughout a project (indentation,
84+
accurate comments, etc.) and any other requirements (such as test coverage).
85+
86+
Adhering to the following process is the best way to get your work
87+
included in the project:
88+
89+
1. [Fork](https://help.github.com/articles/fork-a-repo/) the project, clone your
90+
fork, and configure the remotes:
91+
92+
```bash
93+
# Clone your fork of the repo into the current directory
94+
git clone https://github.com/<your-username>/python-beaver.git
95+
# Navigate to the newly cloned directory
96+
cd python-beaver
97+
# Assign the original repo to a remote called "upstream"
98+
git remote add upstream https://github.com/josegonzalez/python-beaver.git
99+
```
100+
101+
2. If you cloned a while ago, get the latest changes from upstream:
102+
103+
```bash
104+
git checkout master
105+
git pull upstream master
106+
```
107+
108+
3. Create a new topic branch (off the main project development branch) to
109+
contain your feature, change, or fix:
110+
111+
```bash
112+
git checkout -b <topic-branch-name>
113+
```
114+
115+
4. Commit your changes in logical chunks. Please adhere to these [git commit
116+
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
117+
or your code is unlikely be merged into the main project. Use Git's
118+
[interactive rebase](https://help.github.com/articles/about-git-rebase/)
119+
feature to tidy up your commits before making them public.
120+
- Test cases should accompany any change in functionality to the code-base
121+
- Any change to end-user functionality should include corrosponding documentation
122+
123+
5. Locally merge (or rebase) the upstream development branch into your topic branch:
124+
125+
```bash
126+
git pull [--rebase] upstream master
127+
```
128+
129+
6. Run the test suite locally, ensuring they pass:
130+
131+
```bash
132+
nosetests #./install-dependencies.sh to install the pre-requirements
133+
```
134+
135+
7. Push your topic branch up to your fork:
136+
137+
```bash
138+
git push origin <topic-branch-name>
139+
```
140+
141+
8. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
142+
with a clear title and description.
143+
144+
**IMPORTANT**: By submitting a patch, you agree to allow the project
145+
owners to license your work under the terms of the [License](LICENSE.txt).

CONTRIBUTING.rst

Lines changed: 0 additions & 93 deletions
This file was deleted.

0 commit comments

Comments
 (0)