Fix bug in sandbox that caused it to disallow assuments to global let bindings

marijnh · marijnh · commit 539477099450 · 2018-02-03T22:09:17.000+01:00
Closes marijnh#268
diff --git a/html/js/sandbox.js b/html/js/sandbox.js
@@ -371,8 +371,10 @@
         catchPos = stat.end
       }
       if (stat.type == "VariableDeclaration" && stat.kind != "var") {
-        let found = findAssignmentsTo(stat.declarations, ast)
-        if (found) patches.push({from: 0, text: `throw new TypeError("invalid assignment to const '${found}'");`})
+        if (stat.kind == "const") {
+          let found = findAssignmentsTo(stat.declarations, ast)
+          if (found) patches.push({from: 0, text: `throw new TypeError("invalid assignment to const '${found}'");`})
+        }
         patches.push({from: stat.start, to: stat.start + stat.kind.length, text: "var"})
       }
       if (stat.type == "ClassDeclaration")

Original file line number	Diff line number	Diff line change
`@@ -371,8 +371,10 @@`
`371`	`371`	`catchPos = stat.end`
`372`	`372`	`}`
`373`	`373`	`if (stat.type == "VariableDeclaration" && stat.kind != "var") {`
`374`		`- let found = findAssignmentsTo(stat.declarations, ast)`
`375`		- if (found) patches.push({from: 0, text: `throw new TypeError("invalid assignment to const '${found}'");`})
	`374`	`+ if (stat.kind == "const") {`
	`375`	`+ let found = findAssignmentsTo(stat.declarations, ast)`
	`376`	+ if (found) patches.push({from: 0, text: `throw new TypeError("invalid assignment to const '${found}'");`})
	`377`	`+ }`
`376`	`378`	`patches.push({from: stat.start, to: stat.start + stat.kind.length, text: "var"})`
`377`	`379`	`}`
`378`	`380`	`if (stat.type == "ClassDeclaration")`