Throw IOException instead of returning null

dr0i · dr0i · commit 9100b1355770 · 2020-09-08T16:28:33.000+02:00
- remove superfluous check (was always false) - remove superfluous IOException - remove logger as it is no more needed See #292 (comment).
diff --git a/core/src/main/java/com/github/jsonldjava/utils/JsonUtils.java b/core/src/main/java/com/github/jsonldjava/utils/JsonUtils.java
@@ -73,8 +73,6 @@ public class JsonUtils {
     private static volatile CloseableHttpClient DEFAULT_HTTP_CLIENT;
     // Avoid possible endless loop when following alternate locations
     private static final int MAX_LINKS_FOLLOW = 20;
-    private static final Logger log = LoggerFactory.getLogger(JsonUtils.class);
-
 
     static {
         // Disable default Jackson behaviour to close
@@ -371,18 +369,16 @@ private static Object fromJsonLdViaHttpUri(final URL url, final CloseableHttpCli
             if (alternateLink != null) {
                 linksFollowed++;
                 if (linksFollowed > MAX_LINKS_FOLLOW) {
-                    log.warn("Too many alternate links followed. This may indicate a cycle. Aborting.");
-                    return null;
+                    throw new IOException("Too many alternate links followed. This may indicate a cycle. Aborting.");
                 }
-                return linksFollowed > MAX_LINKS_FOLLOW ? null
-                        : fromJsonLdViaHttpUri(alternateLink, httpClient, linksFollowed);
+                return fromJsonLdViaHttpUri(alternateLink, httpClient, linksFollowed);
             }
             return fromInputStream(response.getEntity().getContent());
         }
     }
 
     private static URL alternateLink(URL url, CloseableHttpResponse response)
-            throws MalformedURLException, IOException {
+            throws MalformedURLException {
         if (response.getEntity().getContentType() != null
                 && !response.getEntity().getContentType().getValue().equals("application/ld+json")) {
             for (Header header : response.getAllHeaders()) {
