feat: add integration test for build (googleapis#14319)

ohmayr · web-flow · commit d19c368101e6 · 2025-09-02T15:59:55.000-07:00
diff --git a/.generator/cli.py b/.generator/cli.py
@@ -481,7 +481,7 @@ def handle_build(librarian: str = LIBRARIAN_DIR, repo: str = REPO_DIR):
             "--repo",
             type=str,
             help="Path to the directory in the container which contains google-cloud-python repository",
-            default=SOURCE_DIR,
+            default=REPO_DIR,
         )
     if len(sys.argv) == 1:
         parser.print_help(sys.stderr)
diff --git a/.generator/test-resources/librarian/build-request.json b/.generator/test-resources/librarian/build-request.json
@@ -0,0 +1,40 @@
+{
+  "id": "google-cloud-language",
+  "version": "2.17.2",
+  "last_generated_commit": "97a83d76a09a7f6dcab43675c87bdfeb5bcf1cb5",
+  "apis": [
+    {
+      "path": "google/cloud/language/v1beta2",
+      "service_config": "language_v1beta2.yaml",
+      "status": ""
+    },
+    {
+      "path": "google/cloud/language/v2",
+      "service_config": "language_v2.yaml",
+      "status": ""
+    },
+    {
+      "path": "google/cloud/language/v1",
+      "service_config": "language_v1.yaml",
+      "status": ""
+    }
+  ],
+  "source_roots": [
+    "packages/google-cloud-language"
+  ],
+  "preserve_regex": [
+    ".OwlBot.yaml",
+    "packages/google-cloud-language/CHANGELOG.md",
+    "docs/CHANGELOG.md",
+    "docs/README.rst",
+    "samples/README.txt",
+    "tar.gz",
+    "gapic_version.py",
+    "samples/generated_samples/snippet_metadata_",
+    "scripts/client-post-processing"
+  ],
+  "remove_regex": [
+    "packages/google-cloud-language"
+  ],
+  "tag_format": "{id}-v{version}"
+}
diff --git a/cloudbuild-test.yaml b/cloudbuild-test.yaml
@@ -59,6 +59,24 @@ steps:
       - 'generate'
     waitFor: ['build-generator', 'clone-googleapis']
 
+  # Step 4: Run the generator to test the library code.
+  - name: 'gcr.io/cloud-builders/docker'
+    id: 'build-library'
+    waitFor: ['generate-library']
+    args:
+      - 'run'
+      - '--rm'
+      # Mount the test-resources/librarian from this repo's workspace as the librarian dir.
+      - '-v'
+      - '/workspace/.generator/test-resources/librarian:/app/librarian'
+      # We run the `build` command against the checked in google-cloud-language package.
+      - '-v'
+      - '/workspace:/app/repo'
+      # The image that was built in the first step.
+      - 'gcr.io/$PROJECT_ID/python-librarian-generator:latest'
+      # The command to execute inside the container.
+      - 'build'
+
 options:
   default_logs_bucket_behavior: REGIONAL_USER_OWNED_BUCKET
   machineType: E2_HIGHCPU_32

Original file line number	Diff line number	Diff line change
`@@ -481,7 +481,7 @@ def handle_build(librarian: str = LIBRARIAN_DIR, repo: str = REPO_DIR):`
`481`	`481`	`"--repo",`
`482`	`482`	`type=str,`
`483`	`483`	`help="Path to the directory in the container which contains google-cloud-python repository",`
`484`		`- default=SOURCE_DIR,`
	`484`	`+ default=REPO_DIR,`
`485`	`485`	`)`
`486`	`486`	`if len(sys.argv) == 1:`
`487`	`487`	`parser.print_help(sys.stderr)`