fix(@angular-devkit/build-angular): do not resolve web-workers in server builds

alan-agius4 · filipesilva · commit 77f81dc7f72c · 2021-05-31T12:46:50.000+01:00
Web-workers are not supported on the server and therefore we should not try include them in server builds. Closes angular#20877
diff --git a/packages/angular_devkit/build_angular/src/server/base_spec.ts b/packages/angular_devkit/build_angular/src/server/base_spec.ts
@@ -146,4 +146,31 @@ describe('Server Builder', () => {
 
     await run.stop();
   });
+
+  it('should not try to resolve web-worker', async () => {
+    host.writeMultipleFiles({
+      'src/app/app.worker.ts': `
+        /// <reference lib="webworker" />
+  
+        const foo: string = 'hello world';
+        addEventListener('message', ({ data }) => {
+          postMessage(foo);
+        });
+      `,
+      'src/main.server.ts': `
+        if (typeof Worker !== 'undefined') {
+          const worker = new Worker(new URL('./app/app.worker', import.meta.url), { type: 'module' });
+          worker.onmessage = ({ data }) => {
+            console.log('page got message:', data);
+          };
+          worker.postMessage('hello');
+        }
+      `,
+    });
+
+    const run = await architect.scheduleTarget(target);
+    const output = (await run.result) as ServerBuilderOutput;
+    expect(output.success).toBe(true);
+    await run.stop();
+  });
 });
diff --git a/packages/angular_devkit/build_angular/src/webpack/configs/server.ts b/packages/angular_devkit/build_angular/src/webpack/configs/server.ts
@@ -39,6 +39,14 @@ export function getServerConfig(wco: WebpackConfigOptions): Configuration {
     output: {
       libraryTarget: 'commonjs',
     },
+    module: {
+      parser: {
+        javascript: {
+          worker: false,
+          url: false,
+        },
+      },
+    },
     plugins: [
       // Fixes Critical dependency: the request of a dependency is an expression
       new ContextReplacementPlugin(/@?hapi(\\|\/)/),
