stress/ensure-crash.js shouldn't spew stuff onto my screen

Constellation · Constellation · commit b76a4c746de9 · 2020-04-24T05:14:22.000Z
https://bugs.webkit.org/show_bug.cgi?id=210931 Reviewed by Ross Kirsling. Set noisyOutputHandler when crash! is specified. We also specify noisyOutputHandler for runComplexTest. * Scripts/run-jsc-stress-tests: * Scripts/webkitruby/jsc-stress-test-writer-default.rb: * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb: Canonical link: https://commits.webkit.org/223842@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
@@ -1,3 +1,17 @@
+2020-04-23  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        stress/ensure-crash.js shouldn't spew stuff onto my screen
+        https://bugs.webkit.org/show_bug.cgi?id=210931
+
+        Reviewed by Ross Kirsling.
+
+        Set noisyOutputHandler when crash! is specified. We also specify noisyOutputHandler for runComplexTest.
+
+        * Scripts/run-jsc-stress-tests:
+        * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
+        * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
+        * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
+
 2020-04-23  Yusuke Suzuki  <ysuzuki@apple.com>
 
         Disable useKernTCSM=false for JSC stress tests to make EWS faster
diff --git a/Tools/Scripts/run-jsc-stress-tests b/Tools/Scripts/run-jsc-stress-tests
@@ -1431,7 +1431,7 @@ def runComplexTest(before, after, additionalEnv, *options)
     prepareExtraRelativeFiles(before.map{|v| (Pathname("..") + v).to_s}, $collection)
     prepareExtraRelativeFiles(after.map{|v| (Pathname("..") + v).to_s}, $collection)
     args = [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions + options + before.map{|v| v.to_s} + [$benchmark.to_s] + after.map{|v| v.to_s}
-    addRunCommand("complex", args, silentOutputHandler, simpleErrorHandler, *additionalEnv)
+    addRunCommand("complex", args, noisyOutputHandler, simpleErrorHandler, *additionalEnv)
 end
 
 def runMozillaTest(kind, mode, extraFiles, *options)
diff --git a/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb b/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb
@@ -227,6 +227,9 @@ def initialize(directory, arguments, family, name, outputHandler, errorHandler)
         @errorHandler = errorHandler
         @isSlow = !!$runCommandOptions[:isSlow]
         @shouldCrash = !!$runCommandOptions[:shouldCrash]
+        if @shouldCrash
+            @outputHandler = noisyOutputHandler
+        end
         @additionalEnv = []
     end
     
diff --git a/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb b/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb
@@ -273,6 +273,9 @@ def initialize(directory, arguments, family, name, outputHandler, errorHandler)
         @errorHandler = errorHandler
         @isSlow = !!$runCommandOptions[:isSlow]
         @shouldCrash = !!$runCommandOptions[:shouldCrash]
+        if @shouldCrash
+            @outputHandler = noisyOutputHandler
+        end
         @additionalEnv = []
     end
 
diff --git a/Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb b/Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb
@@ -273,6 +273,9 @@ def initialize(directory, arguments, family, name, outputHandler, errorHandler)
         @errorHandler = errorHandler
         @isSlow = !!$runCommandOptions[:isSlow]
         @shouldCrash = !!$runCommandOptions[:shouldCrash]
+        if @shouldCrash
+            @outputHandler = noisyOutputHandler
+        end
         @additionalEnv = []
     end
     
