Fix: cleanup old polyfills#3524
Merged
Merged
Conversation
Owner
Author
|
Published now in |
|
Great. F.Y.I : as asked publication of corresponding version in new WebJar - see: webjars/mathjs#7 Thanks for your impressive reactivness anyway. |
Owner
Author
|
Thanks. I'm not always fast though but this was indeed quickly resolved 😅. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3523.
Removes redundant polyfills in the mathjs bundle included by
js-core. This reduces the (minified, non-zipped) bundle/lib/browser/math.jsfrom 677 KB to 628 KB. It also removes polyfill code likenew ActiveXObject("htmlfile"), which could trigger security issues.The bundle is still es2020 compatible. This is the minimum version required since
mathjs@13.0.0. This is validated using thees-checklibrary. You can test this by adding some code that uses a newer method like.toSorted, and then executenpm run build-and-testand see that a compatibility error is reported.