feat(types): Add missing type definition for diff function#3520
Merged
Conversation
Contributor
Author
|
@josdejong can u please review this pr? |
Owner
|
Thanks @dodokw ! Two remarks:
|
Contributor
Author
|
@josdejong |
Owner
|
Thanks for the update @dodokw, this looks good! Last thing: can you undo the formatting changes in |
Contributor
Author
|
@josdejong |
Owner
|
👌 thank you! |
Owner
|
Fixed now in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the
difffunction, which exists in the JavaScript implementation, is missing from the TypeScript type definitions (index.d.ts). This omission causes a type error in TypeScript projects when trying to usemath.diff(), even though the function works correctly at runtime.