sign of zero fraction should return 0/1 instead of 1/1#3513
Merged
Conversation
josdejong
reviewed
Jul 23, 2025
Owner
josdejong
left a comment
There was a problem hiding this comment.
Thanks Kyle! I made one small inline remark, can you have a look at that?
Author
|
All fixed :D Moved testcase into correct function block |
Owner
|
Thanks again! |
Owner
|
The fix is published now in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Issue: #3512
Fixed:
issue where math.sign(math.fraction(0)) incorrectly returned 1/1 instead of 0/1. Changed fraction sign detection from checking x.s to checking x.n === 0n (numerator is
Modified:
/function/arithmetic/sign.js:55 - Changed from
return new Fraction(x.s)toreturn x.n === 0n ? new Fraction(0) : new Fraction(x.s)Added:
test/unit-tests/function/arithmetic/sign.test.js:108-110 - Added test case for
math.sign(math.fraction(0))npm run lintandnpm testhad no issues :)