fixed matrix issue in correlation function + error handling#3030
Merged
josdejong merged 10 commits intoSep 20, 2023
Conversation
josdejong
reviewed
Sep 15, 2023
Owner
josdejong
left a comment
There was a problem hiding this comment.
Thanks for picking this up! I like all the extra validations and the unit tests for that, thanks. I made two inline comments, can you have a look at that?
77cdff9 to
863ee9c
Compare
Contributor
Author
|
@josdejong changes has been made. please have a look. |
Owner
|
Thanks this looks 👌 |
Owner
|
The fix is published now in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @josdejong,
This PR will fix issue #3025 please check.