implement solveODE#2958
Conversation
josdejong
left a comment
There was a problem hiding this comment.
Thanks a lot David, this looks really neat. The code looks very clean and easy to follow. I made a couple of inline comments, can you have a look at those? (nothing big)
|
O, and I see one of the CI tests fails because there are no embedded docs. Can you add a file |
|
Hi Jos, thank you for your through review. Everything is very clear, I will work on that, I just included a few comments regarding error messages. |
|
Thank you very much for the review. Here is an overview of the changes
Here is the bad part:
|
|
Now it works with big numbers |
|
These are the recent changes:
Some drawbacks is that now instead of just solving some cases it throws an error, bit it might be ok. |
|
Thanks for the updates David. All looks good to go 👌 |
|
That's great news! Thanks! |
|
Published now in |
Hi, this includes a function to do numeric integration of ordinary differential equations in a similar fashion to scipy.integrate.solve_ivp.
It includes Runge-Kutta methods with variable step size 'RK45' and 'RK23'.
Some ideas for the future are:
myF(t, y, a, b, c)we could include in options{args: [a, b, c]}instead of making a new function of the formf(t, y)