Fix min as short for minim not minute in documentation#2773
Merged
josdejong merged 1 commit intoSep 12, 2022
Conversation
Contributor
Author
|
I know this is a tiny change but it caused me to recheck if all our tests are working properly (with a little panic if we have been converting time to some volume unit) 😄 |
Owner
😂 you where probably just in time, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in the documentation
minis marked as short for the volume unitminim. This is not the case since it is used as the short form ofminute. See:Commented out minim definition:
mathjs/src/type/unit/Unit.js
Line 1896 in 1947257
and the actual minute definition:
mathjs/src/type/unit/Unit.js
Lines 2094 to 2100 in 1947257
This MR simply moves min to the correct row in the table.