Call toTex on expression arg of derivative if it is a node#2564
Merged
josdejong merged 1 commit intoMay 20, 2022
Conversation
2117a4d to
b775b8e
Compare
b775b8e to
41f1152
Compare
Owner
|
Ah, that makes sense, should indeed be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
Not sure if there's a good reason for this, but currently the expression argument of
derivative(expr,x)is not TeX-ified when callingtoTex()on the derivative node. This is a bit suprising since other functions seems to do this.Compare the behaviour of
derivative(expr, var)toadd(x, y):Looks like we're just calling
toString()when the expression is aNode: https://github.com/josdejong/mathjs/blob/develop/src/function/algebra/derivative.js#L132The solution
This PR simply calls toTex on the expression arg if it's a Node