Skip to content

Feature: pow(matrix, n) generalization to negative exponents#2517

Merged
gwhitney merged 8 commits into
josdejong:developfrom
HanchaiN:pow-matrix-negative
Apr 8, 2022
Merged

Feature: pow(matrix, n) generalization to negative exponents#2517
gwhitney merged 8 commits into
josdejong:developfrom
HanchaiN:pow-matrix-negative

Conversation

@HanchaiN
Copy link
Copy Markdown
Contributor

@HanchaiN HanchaiN commented Apr 4, 2022

Fix #2463

@gwhitney
Copy link
Copy Markdown
Collaborator

gwhitney commented Apr 6, 2022

Thank you for the submission! The comment just below createPow in pow.js also needs to be updated, and in the examples there it would be good if at least one of the examples used a negative and/or non-integer exponent. It would also be good if there was a matrix example (not necessarily with negative exponent, either way) in src/expression/embeddedDocs/function/arithmetic/pow.js. If you can make these documentation changes we should be able to move this PR along, thanks!

@HanchaiN
Copy link
Copy Markdown
Contributor Author

HanchaiN commented Apr 6, 2022

The documentation has been updated, thanks.

@gwhitney
Copy link
Copy Markdown
Collaborator

gwhitney commented Apr 7, 2022

This is looking quite reasonable. Turning on the regression tests in this PR.

@gwhitney
Copy link
Copy Markdown
Collaborator

gwhitney commented Apr 8, 2022

Hmm, there's still a failure in build-and-test; I don't know why, but I can never see the error in these CI reports. But anyway @HanchaiN you can run npm run build-and-test locally on your end and see what is up, thanks.

@gwhitney gwhitney merged commit 7480c11 into josdejong:develop Apr 8, 2022
@HanchaiN HanchaiN deleted the pow-matrix-negative branch April 8, 2022 19:38
@HanchaiN HanchaiN changed the title Fix #2463 Feature: pow(matrix, n) generalization to negative exponents Apr 9, 2022
@josdejong
Copy link
Copy Markdown
Owner

Thanks again @HanchaiN 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pow(matrix, n) can easily be extended to negative n

3 participants