Providing overridable Unit.isValidAlpha#2000
Merged
josdejong merged 3 commits intoOct 28, 2020
Merged
Conversation
Owner
|
Looks good @rnd-debug , thanks! Can you please write a unit test to test the new functionality? |
Owner
|
O, and I think we should document this else nobody knows that this is possible |
Contributor
Author
|
Ok, pushed some tests and an addition to docs/datatypes/units.md, assuming that this file is used to generate https://mathjs.org/docs/datatypes/units.html |
Owner
|
Thanks @rnd-debug, looks good ! |
Owner
|
The new function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.