Updated Diff function#1920
Merged
Merged
Conversation
Shouldnt provide any issues for other systems I hope
This reverts commit 4cd2704.
This reverts commit 268b594.
Added tests and then fixed all linting issues
Tests for bignumber, fraction and units.
Added Unit tests for the 4 Errors. Also changed some small things
Matrices are all treated as arrays (of arrays) now. This was to prep for writing better docs
Currently it does say that it will be one-based in the parser but I havent done that yet
Also added bignumbers as indexes as that could be useful
Closed
Owner
|
All works like a charm, also the transform. And all is very well tested @Veeloxfire 👍 . Thanks a lot. |
Owner
|
For some reason some of the unit tests where failing on IE 11 (I think not directly related to |
Owner
|
The new function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this covers everything mentioned in #1812
I've also made it so that arrays containing matrices work as if they were just arrays. This means that you can now do the difference between a matrix and an array which I think would have thrown an error before.
I've made it so that bignumbers can be used as indexes but I think someone should look at that and check that I havent made any errors as I've never used them before