Skip to content

don't fail on bad Accept-Language header #374

@jknack

Description

@jknack

We should silently ignore wrong/bad Accept-Language headers. Today we throw a 400 error:

Caused by: java.lang.IllegalArgumentException: range=en;
    at java.util.Locale$LanguageRange.<init>(Locale.java:2913) ~[na:1.8.0_66]
    at sun.util.locale.LocaleMatcher.parse(LocaleMatcher.java:284) ~[na:1.8.0_66]
    at java.util.Locale$LanguageRange.parse(Locale.java:3028) ~[na:1.8.0_66]
    at org.jooby.internal.LocaleUtils.range(LocaleUtils.java:53) ~[hlrs.jar:1.0-SNAPSHOT]
    at org.jooby.internal.LocaleUtils.parse(LocaleUtils.java:43) ~[hlrs.jar:1.0-SNAPSHOT]
    at org.jooby.internal.RequestImpl.lambda$locales$9(RequestImpl.java:277) ~[hlrs.jar:1.0-SNAPSHOT]
    at java.util.Optional.map(Optional.java:215) ~[na:1.8.0_66]
    at org.jooby.internal.RequestImpl.locales(RequestImpl.java:277) ~[hlrs.jar:1.0-SNAPSHOT]

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions