jackson optimize if-else

Harry Chan · Harry Chan · commit 1206368651f1 · 2020-12-20T20:30:18.000+11:00
Remove extra else in if-else in Jackson Module
diff --git a/modules/jooby-jackson/src/main/java/io/jooby/json/JacksonModule.java b/modules/jooby-jackson/src/main/java/io/jooby/json/JacksonModule.java
@@ -138,16 +138,14 @@ public JacksonModule module(Class<? extends Module> module) {
     if (body.isInMemory()) {
       if (type == JsonNode.class) {
         return mapper.readTree(body.bytes());
-      } else {
-        return mapper.readValue(body.bytes(), typeFactory.constructType(type));
       }
+      return mapper.readValue(body.bytes(), typeFactory.constructType(type));
     } else {
       try (InputStream stream = body.stream()) {
         if (type == JsonNode.class) {
           return mapper.readTree(stream);
-        } else {
-          return mapper.readValue(stream, typeFactory.constructType(type));
         }
+        return mapper.readValue(stream, typeFactory.constructType(type));
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -138,16 +138,14 @@ public JacksonModule module(Class<? extends Module> module) {`
`138`	`138`	`if (body.isInMemory()) {`
`139`	`139`	`if (type == JsonNode.class) {`
`140`	`140`	`return mapper.readTree(body.bytes());`
`141`		`- } else {`
`142`		`- return mapper.readValue(body.bytes(), typeFactory.constructType(type));`
`143`	`141`	`}`
	`142`	`+ return mapper.readValue(body.bytes(), typeFactory.constructType(type));`
`144`	`143`	`} else {`
`145`	`144`	`try (InputStream stream = body.stream()) {`
`146`	`145`	`if (type == JsonNode.class) {`
`147`	`146`	`return mapper.readTree(stream);`
`148`		`- } else {`
`149`		`- return mapper.readValue(stream, typeFactory.constructType(type));`
`150`	`147`	`}`
	`148`	`+ return mapper.readValue(stream, typeFactory.constructType(type));`
`151`	`149`	`}`
`152`	`150`	`}`
`153`	`151`	`}`