decoder example gives an error fix #1547

jknack · jknack · commit 0f4471c82647 · 2020-03-12T20:26:04.000-03:00
diff --git a/jooby/src/main/java/io/jooby/DefaultContext.java b/jooby/src/main/java/io/jooby/DefaultContext.java
@@ -396,7 +396,7 @@ public interface DefaultContext extends Context {
           return result;
         }
       }
-      return decoder(contentType).decode(this, type);
+      return (T) decoder(contentType).decode(this, type);
     } catch (Exception x) {
       throw SneakyThrows.propagate(x);
     }
diff --git a/jooby/src/main/java/io/jooby/MessageDecoder.java b/jooby/src/main/java/io/jooby/MessageDecoder.java
@@ -21,20 +21,17 @@ public interface MessageDecoder {
   /**
    * Resolve parsing as {@link StatusCode#UNSUPPORTED_MEDIA_TYPE}.
    */
-  MessageDecoder UNSUPPORTED_MEDIA_TYPE = new MessageDecoder() {
-    @Override public <T> T decode(Context ctx, Type type) {
-      throw new UnsupportedMediaType(ctx.header("Content-Type").valueOrNull());
-    }
+  MessageDecoder UNSUPPORTED_MEDIA_TYPE = (ctx, type) -> {
+    throw new UnsupportedMediaType(ctx.header("Content-Type").valueOrNull());
   };
 
   /**
    * Parse HTTP body into the given type.
    *
    * @param ctx Web context.
    * @param type Target/expected type.
-   * @param <T> Dynamic binding of the target type.
    * @return An instance of the target type.
    * @throws Exception Is something goes wrong.
    */
-  @Nonnull <T> T decode(@Nonnull Context ctx, @Nonnull Type type) throws Exception;
+  @Nonnull Object decode(@Nonnull Context ctx, @Nonnull Type type) throws Exception;
 }
diff --git a/modules/jooby-jackson/src/main/java/io/jooby/json/JacksonModule.java b/modules/jooby-jackson/src/main/java/io/jooby/json/JacksonModule.java
@@ -132,20 +132,20 @@ public JacksonModule module(Class<? extends Module> module) {
     return mapper.writer().writeValueAsBytes(value);
   }
 
-  @Override public <T> T decode(Context ctx, Type type) throws Exception {
+  @Override public Object decode(Context ctx, Type type) throws Exception {
     Body body = ctx.body();
     if (body.isInMemory()) {
       if (type == JsonNode.class) {
-        return (T) mapper.readTree(body.bytes());
+        return mapper.readTree(body.bytes());
       } else {
-        return (T) mapper.readValue(body.bytes(), typeFactory.constructType(type));
+        return mapper.readValue(body.bytes(), typeFactory.constructType(type));
       }
     } else {
       try (InputStream stream = body.stream()) {
         if (type == JsonNode.class) {
-          return (T) mapper.readTree(stream);
+          return mapper.readTree(stream);
         } else {
-          return (T) mapper.readValue(stream, typeFactory.constructType(type));
+          return mapper.readValue(stream, typeFactory.constructType(type));
         }
       }
     }
diff --git a/modules/jooby-jackson/src/test/java/io/jooby/json/JacksonModuleTest.java b/modules/jooby-jackson/src/test/java/io/jooby/json/JacksonModuleTest.java
@@ -40,7 +40,7 @@ public void parse() throws Exception {
 
     JacksonModule jackson = new JacksonModule();
 
-    Map<String, String> result = jackson.decode(ctx, Map.class);
+    Map<String, String> result = (Map<String, String>) jackson.decode(ctx, Map.class);
     assertEquals(mapOf("k", "v"), result);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,7 @@ public interface DefaultContext extends Context {`
`396`	`396`	`return result;`
`397`	`397`	`}`
`398`	`398`	`}`
`399`		`- return decoder(contentType).decode(this, type);`
	`399`	`+ return (T) decoder(contentType).decode(this, type);`
`400`	`400`	`} catch (Exception x) {`
`401`	`401`	`throw SneakyThrows.propagate(x);`
`402`	`402`	`}`
Original file line number	Diff line number	Diff line change
`@@ -132,20 +132,20 @@ public JacksonModule module(Class<? extends Module> module) {`
`132`	`132`	`return mapper.writer().writeValueAsBytes(value);`
`133`	`133`	`}`
`134`	`134`
`135`		`- @Override public <T> T decode(Context ctx, Type type) throws Exception {`
	`135`	`+ @Override public Object decode(Context ctx, Type type) throws Exception {`
`136`	`136`	`Body body = ctx.body();`
`137`	`137`	`if (body.isInMemory()) {`
`138`	`138`	`if (type == JsonNode.class) {`
`139`		`- return (T) mapper.readTree(body.bytes());`
	`139`	`+ return mapper.readTree(body.bytes());`
`140`	`140`	`} else {`
`141`		`- return (T) mapper.readValue(body.bytes(), typeFactory.constructType(type));`
	`141`	`+ return mapper.readValue(body.bytes(), typeFactory.constructType(type));`
`142`	`142`	`}`
`143`	`143`	`} else {`
`144`	`144`	`try (InputStream stream = body.stream()) {`
`145`	`145`	`if (type == JsonNode.class) {`
`146`		`- return (T) mapper.readTree(stream);`
	`146`	`+ return mapper.readTree(stream);`
`147`	`147`	`} else {`
`148`		`- return (T) mapper.readValue(stream, typeFactory.constructType(type));`
	`148`	`+ return mapper.readValue(stream, typeFactory.constructType(type));`
`149`	`149`	`}`
`150`	`150`	`}`
`151`	`151`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public void parse() throws Exception {`
`40`	`40`
`41`	`41`	`JacksonModule jackson = new JacksonModule();`
`42`	`42`
`43`		`- Map<String, String> result = jackson.decode(ctx, Map.class);`
	`43`	`+ Map<String, String> result = (Map<String, String>) jackson.decode(ctx, Map.class);`
`44`	`44`	`assertEquals(mapOf("k", "v"), result);`
`45`	`45`	`}`
`46`	`46`