Add support for token caching

gtema · gtema · commit 30d5f14a700d · 2020-12-05T15:40:24.000+01:00
SDK starts caching token in keyring (when available and configured). A small change is required in OSC not to reject this state. Overall this helps avoiding reauthentication upon next openstack call. If token is not valid anymore automatically reauthentication is done. Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/735352 Depends-On: https://review.opendev.org/c/openstack/osc-lib/+/765650 Change-Id: I47261a32bd3b106a589974d3de5bf2a6ebd57263
diff --git a/openstackclient/common/clientmanager.py b/openstackclient/common/clientmanager.py
@@ -83,10 +83,12 @@ def setup_auth(self):
             self._cli_options._openstack_config._pw_callback = \
                 shell.prompt_for_password
             try:
-                self._cli_options._auth = \
-                    self._cli_options._openstack_config.load_auth_plugin(
-                        self._cli_options.config,
-                    )
+                # We might already get auth from SDK caching
+                if not self._cli_options._auth:
+                    self._cli_options._auth = \
+                        self._cli_options._openstack_config.load_auth_plugin(
+                            self._cli_options.config,
+                        )
             except TypeError as e:
                 self._fallback_load_auth_plugin(e)
 
