Merge pull request #2 from jobayer1V/revert-1-master

jobayer1V · web-flow · commit d546033eaa32 · 2025-07-12T15:03:16.000Z
Revert "Fix infinite loop crash in variable type inference (PowerShell#25696)"
diff --git a/src/System.Management.Automation/engine/parser/Position.cs b/src/System.Management.Automation/engine/parser/Position.cs
@@ -338,7 +338,10 @@ internal static bool IsAfter(this IScriptExtent extentToTest, IScriptExtent endE
 
         internal static bool IsWithin(this IScriptExtent extentToTest, IScriptExtent extent)
         {
-            return extentToTest.StartOffset >= extent.StartOffset && extentToTest.EndOffset <= extent.EndOffset;
+            return extentToTest.StartLineNumber >= extent.StartLineNumber &&
+                   extentToTest.EndLineNumber <= extent.EndLineNumber &&
+                   extentToTest.StartColumnNumber >= extent.StartColumnNumber &&
+                   extentToTest.EndColumnNumber <= extent.EndColumnNumber;
         }
 
         internal static bool IsAfter(this IScriptExtent extent, int line, int column)

Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,10 @@ internal static bool IsAfter(this IScriptExtent extentToTest, IScriptExtent endE`
`338`	`338`
`339`	`339`	`internal static bool IsWithin(this IScriptExtent extentToTest, IScriptExtent extent)`
`340`	`340`	`{`
`341`		`- return extentToTest.StartOffset >= extent.StartOffset && extentToTest.EndOffset <= extent.EndOffset;`
	`341`	`+ return extentToTest.StartLineNumber >= extent.StartLineNumber &&`
	`342`	`+ extentToTest.EndLineNumber <= extent.EndLineNumber &&`
	`343`	`+ extentToTest.StartColumnNumber >= extent.StartColumnNumber &&`
	`344`	`+ extentToTest.EndColumnNumber <= extent.EndColumnNumber;`
`342`	`345`	`}`
`343`	`346`
`344`	`347`	`internal static bool IsAfter(this IScriptExtent extent, int line, int column)`