Fixed a bug in configuration read.

carlos-jenkins · carlos-jenkins · commit ed56e6df9274 · 2014-09-23T16:10:05.000-06:00
diff --git a/README.rst b/README.rst
@@ -66,20 +66,19 @@ and has a shebang. A simple example in Python could be:
 
     #!/usr/bin/env python
     # Python Example for Python GitHub Webhooks
+    # File: push-myrepo-master
 
-    import os
     import sys
     import json
-    from tempfile import mkstemp
 
     payload = json.loads(sys.argv[1])
-    _, tmpfile = mkstemp()
 
     ### Do something with the payload
-    if payload['repository']['name'] == 'my-repo-name':
-        f = open(tmpfile, 'w')
+    name = payload['repository']['name']
+    outfile = '/tmp/hook-{}.log'.format(name)
+
+    with open(outfile, 'w') as f:
         f.write(json.dumps(payload))
-        f.close()
 
 
 Test
diff --git a/webhooks.py b/webhooks.py
@@ -38,8 +38,11 @@
 @application.route('/', methods=['GET', 'POST'])
 def index():
     """
+    Main WSGI application entry.
     """
-    hooks = join(normpath(abspath(dirname(__file__))), 'hooks')
+
+    path = normpath(abspath(dirname(__file__)))
+    hooks = join(path, 'hooks')
 
     whitelist = requests.get('https://api.github.com/meta').json()['hooks']
 
@@ -48,7 +51,7 @@ def index():
         abort(501)
 
     # Load config
-    with open('config.json', 'r') as cfg:
+    with open(join(path, 'config.json'), 'r') as cfg:
         config = loads(cfg.read())
 
     # Allow Github IPs only
