crypto: fix signed/unsigned comparison warning

bnoordhuis · bnoordhuis · commit 576496632c96 · 2013-08-06T15:39:43.000+02:00
The type of the expression `(uint16_t) server_names_len + 2` gets
implicitly widened to int. Change the type of server_names_len to
uint32_t to avoid the following warnings:

    ../../src/node_crypto_clienthello.cc:144: warning: comparison
    between signed and unsigned integer expressions
    ../../src/node_crypto_clienthello.cc:146: warning: comparison
    between signed and unsigned integer expressions
diff --git a/src/node_crypto_clienthello.cc b/src/node_crypto_clienthello.cc
@@ -140,7 +140,7 @@ void ClientHelloParser::ParseExtension(ClientHelloParser::ExtensionType type,
       {
         if (len < 2)
           return;
-        uint16_t server_names_len = (data[0] << 8) + data[1];
+        uint32_t server_names_len = (data[0] << 8) + data[1];
         if (server_names_len + 2 > len)
           return;
         for (size_t offset = 2; offset < 2 + server_names_len; ) {

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ void ClientHelloParser::ParseExtension(ClientHelloParser::ExtensionType type,`
`140`	`140`	`{`
`141`	`141`	`if (len < 2)`
`142`	`142`	`return;`
`143`		`- uint16_t server_names_len = (data[0] << 8) + data[1];`
	`143`	`+ uint32_t server_names_len = (data[0] << 8) + data[1];`
`144`	`144`	`if (server_names_len + 2 > len)`
`145`	`145`	`return;`
`146`	`146`	`for (size_t offset = 2; offset < 2 + server_names_len; ) {`