Skip to content

Commit 5dbe83c

Browse files
committed
Revert "test_packages_distributions_all_module_types: Create valid import names"
This reverts commit 70ff991. This behavior was adopted in 5e8260c and subsequently adapted as part of python#443.
1 parent 70ff991 commit 5dbe83c

1 file changed

Lines changed: 7 additions & 12 deletions

File tree

tests/test_main.py

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -342,10 +342,10 @@ def test_packages_distributions_all_module_types(self):
342342
filenames = list(
343343
itertools.chain.from_iterable(
344344
[
345-
f'top_level_{i}{suffix}',
346-
f'in_namespace_{i}/mod{suffix}',
347-
f'in_package_{i}/__init__.py',
348-
f'in_package_{i}/mod{suffix}',
345+
f'{i}-top-level{suffix}',
346+
f'{i}-in-namespace/mod{suffix}',
347+
f'{i}-in-package/__init__.py',
348+
f'{i}-in-package/mod{suffix}',
349349
]
350350
for i, suffix in enumerate(suffixes)
351351
)
@@ -367,14 +367,9 @@ def test_packages_distributions_all_module_types(self):
367367
distributions = packages_distributions()
368368

369369
for i in range(len(suffixes)):
370-
assert distributions[f'top_level_{i}'] == ['all_distributions']
371-
assert distributions[f'in_namespace_{i}'] == ['all_distributions']
372-
assert distributions[f'in_package_{i}'] == ['all_distributions']
373-
374-
# All keys returned from packages_distributions() should be valid import
375-
# names, which means that they must _at least_ be valid identifiers:
376-
for import_name in distributions.keys():
377-
assert import_name.isidentifier(), import_name
370+
assert distributions[f'{i}-top-level'] == ['all_distributions']
371+
assert distributions[f'{i}-in-namespace'] == ['all_distributions']
372+
assert distributions[f'{i}-in-package'] == ['all_distributions']
378373

379374

380375
class PackagesDistributionsEggTest(

0 commit comments

Comments
 (0)