Revert "fix: Update milvus connect function to work with remote instance" (feast-dev#5398)

franciscojavierarceo · jfw-ppi · commit d68fda660bbb · 2025-06-07T20:55:32.000+02:00
Revert "fix: Update milvus connect function to work with remote instance (feast-dev#5382)" This reverts commit 7e5e7d5. Signed-off-by: Jacob Weinhold <29459386+j-wine@users.noreply.github.com>
diff --git a/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py b/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
@@ -88,7 +88,7 @@ class MilvusOnlineStoreConfig(FeastConfigBaseModel, VectorStoreConfig):
     """
 
     type: Literal["milvus"] = "milvus"
-    path: Optional[StrictStr] = ""
+    path: Optional[StrictStr] = "online_store.db"
     host: Optional[StrictStr] = "localhost"
     port: Optional[int] = 19530
     index_type: Optional[str] = "FLAT"
@@ -126,16 +126,13 @@ def _get_db_path(self, config: RepoConfig) -> str:
 
     def _connect(self, config: RepoConfig) -> MilvusClient:
         if not self.client:
-            if config.provider == "local" and config.online_store.path:
+            if config.provider == "local":
                 db_path = self._get_db_path(config)
                 print(f"Connecting to Milvus in local mode using {db_path}")
                 self.client = MilvusClient(db_path)
             else:
-                print(
-                    f"Connecting to Milvus remotely at {config.online_store.host}:{config.online_store.port}"
-                )
                 self.client = MilvusClient(
-                    uri=f"{config.online_store.host}:{config.online_store.port}",
+                    url=f"{config.online_store.host}:{config.online_store.port}",
                     token=f"{config.online_store.username}:{config.online_store.password}"
                     if config.online_store.username and config.online_store.password
                     else "",
