fix: The ignore_paths not taking effect duration feast apply (feast-dev#5353)

joeyutong · jfw-ppi · commit 86c301579242 · 2025-06-07T20:55:30.000+02:00
fix: ignore_paths not taking effect

Signed-off-by: joeyutong &lt;joeyutong@gmail.com&gt;
Signed-off-by: Jacob Weinhold &lt;29459386+j-wine@users.noreply.github.com&gt;
diff --git a/sdk/python/feast/repo_operations.py b/sdk/python/feast/repo_operations.py
@@ -69,7 +69,7 @@ def read_feastignore(repo_root: Path) -> List[str]:
 def get_ignore_files(repo_root: Path, ignore_paths: List[str]) -> Set[Path]:
     """Get all ignore files that match any of the user-defined ignore paths"""
     ignore_files = set()
-    for ignore_path in ignore_paths:
+    for ignore_path in set(ignore_paths):
         # ignore_path may contains matchers (* or **). Use glob() to match user-defined path to actual paths
         for matched_path in repo_root.glob(ignore_path):
             if matched_path.is_file():
@@ -88,16 +88,15 @@ def get_ignore_files(repo_root: Path, ignore_paths: List[str]) -> Set[Path]:
 def get_repo_files(repo_root: Path) -> List[Path]:
     """Get the list of all repo files, ignoring undesired files & directories specified in .feastignore"""
     # Read ignore paths from .feastignore and create a set of all files that match any of these paths
-    ignore_paths = read_feastignore(repo_root)
-    ignore_files = get_ignore_files(repo_root, ignore_paths)
-    ignore_paths += [
+    ignore_paths = read_feastignore(repo_root) + [
         ".git",
         ".feastignore",
         ".venv",
         ".pytest_cache",
         "__pycache__",
         ".ipynb_checkpoints",
     ]
+    ignore_files = get_ignore_files(repo_root, ignore_paths)
 
     # List all Python files in the root directory (recursively)
     repo_files = {
diff --git a/sdk/python/tests/unit/infra/scaffolding/test_repo_operations.py b/sdk/python/tests/unit/infra/scaffolding/test_repo_operations.py
@@ -30,7 +30,7 @@ def feature_repo(feastignore_contents: Optional[str]):
         (repo_root / "bar/subdir1/subdir2").mkdir()
 
         (repo_root / "a.py").touch()
-        (repo_root / ".ipynb_checkpoints/test-checkpoint.ipynb").touch()
+        (repo_root / ".ipynb_checkpoints/test-checkpoint.py").touch()
         (repo_root / "foo/b.py").touch()
         (repo_root / "foo1/c.py").touch()
         (repo_root / "foo1/bar/d.py").touch()
