Skip to content

Commit fc9e71b

Browse files
authored
chore: restore PY_VERSION (googleapis#13776)
`PY_VERSION` is only used when `TEST_TYPE` environment variable is set to `unit`. We can set `PY_VERSION` to `unused` otherwise to reflect that it is not being. See googleapis#13775 to follow up on supporting `PY_VERSION` for all values of `TEST_TYPE`, rather than just `unit`
1 parent f84bb25 commit fc9e71b

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

.github/workflows/docs.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ jobs:
6363
env:
6464
BUILD_TYPE: presubmit
6565
TEST_TYPE: docs
66-
PY_VERSION: "3.10"
66+
# TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
67+
PY_VERSION: "unused"
6768
run: |
6869
ci/run_conditional_tests.sh
6970
docs-warnings:
@@ -91,7 +92,8 @@ jobs:
9192
env:
9293
BUILD_TYPE: presubmit
9394
TEST_TYPE: docs
94-
PY_VERSION: "3.10"
95+
# TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
96+
PY_VERSION: "unused"
9597
run: |
9698
ci/run_conditional_tests.sh
9799
docfx:
@@ -117,7 +119,8 @@ jobs:
117119
env:
118120
BUILD_TYPE: presubmit
119121
TEST_TYPE: docfx
120-
PY_VERSION: "3.10"
122+
# TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
123+
PY_VERSION: "unused"
121124
run: |
122125
ci/run_conditional_tests.sh
123126
docfx-warnings:
@@ -145,6 +148,7 @@ jobs:
145148
env:
146149
BUILD_TYPE: presubmit
147150
TEST_TYPE: docfx
148-
PY_VERSION: "3.10"
151+
# TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
152+
PY_VERSION: "unused"
149153
run: |
150154
ci/run_conditional_tests.sh

.github/workflows/lint.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,15 @@ jobs:
3434
env:
3535
BUILD_TYPE: presubmit
3636
TEST_TYPE: lint
37+
# TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
38+
PY_VERSION: "unused"
3739
run: |
3840
ci/run_conditional_tests.sh
3941
- name: Run lint_setup_py
4042
env:
4143
BUILD_TYPE: presubmit
4244
TEST_TYPE: lint_setup_py
45+
# TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
46+
PY_VERSION: "unused"
4347
run: |
4448
ci/run_conditional_tests.sh

.github/workflows/unittest.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ jobs:
7676
env:
7777
BUILD_TYPE: presubmit
7878
TEST_TYPE: ${{ matrix.option }}
79-
PY_VERSION: ${{ matrix.python }}
79+
# TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
80+
PY_VERSION: "unused"
8081
run: |
8182
ci/run_conditional_tests.sh
8283

0 commit comments

Comments
 (0)