framebufferio: Fix crash calling unimplemented get_brightness

jepler · jepler · commit ffc488e74889 · 2020-08-12T07:32:18.000-05:00
If set_brightness was implemented but get_brightness wasn't, this
would hard fault
diff --git a/shared-module/framebufferio/FramebufferDisplay.c b/shared-module/framebufferio/FramebufferDisplay.c
@@ -109,7 +109,7 @@ bool common_hal_framebufferio_framebufferdisplay_set_auto_brightness(framebuffer
 }
 
 mp_float_t common_hal_framebufferio_framebufferdisplay_get_brightness(framebufferio_framebufferdisplay_obj_t* self) {
-    if (self->framebuffer_protocol->set_brightness) {
+    if (self->framebuffer_protocol->get_brightness) {
         return self->framebuffer_protocol->get_brightness(self->framebuffer);
     }
     return -1;

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ bool common_hal_framebufferio_framebufferdisplay_set_auto_brightness(framebuffer`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`mp_float_t common_hal_framebufferio_framebufferdisplay_get_brightness(framebufferio_framebufferdisplay_obj_t* self) {`
`112`		`- if (self->framebuffer_protocol->set_brightness) {`
	`112`	`+ if (self->framebuffer_protocol->get_brightness) {`
`113`	`113`	`return self->framebuffer_protocol->get_brightness(self->framebuffer);`
`114`	`114`	`}`
`115`	`115`	`return -1;`