Fix for unhandled undefined config in reset password pages (parse-community#4334)

bryandel · flovilmart · commit 4e207d32a7e5 · 2017-11-11T09:42:20.000-05:00
* Fix for unhandled undefined config

When an invalid application id is passed either for reset/change password or email verification, config.get returns undefined. This causes internal server.

* Throwing a 403 exception instead of returning a 404 for an invalid app id

Also, added a missing semicolon

* Fix indent issues

* Fix invalid colon to semicolon

* Fix space and indent issues

* Tests for the fix for unhandled undefined config
diff --git a/spec/PublicAPI.spec.js b/spec/PublicAPI.spec.js
@@ -63,3 +63,47 @@ describe("public API without publicServerURL", () => {
     });
   });
 });
+
+
+describe("public API supplied with invalid application id", () => {
+  beforeEach(done => {
+    reconfigureServer({appName: "unused"})
+      .then(done, fail);
+  });
+
+  it("should get 403 on verify_email", (done) => {
+    request('http://localhost:8378/1/apps/invalid/verify_email', (err, httpResponse) => {
+      expect(httpResponse.statusCode).toBe(403);
+      done();
+    });
+  });
+
+  it("should get 403 choose_password", (done) => {
+    request('http://localhost:8378/1/apps/choose_password?id=invalid', (err, httpResponse) => {
+      expect(httpResponse.statusCode).toBe(403);
+      done();
+    });
+  });
+
+  it("should get 403 on get of request_password_reset", (done) => {
+    request('http://localhost:8378/1/apps/invalid/request_password_reset', (err, httpResponse) => {
+      expect(httpResponse.statusCode).toBe(403);
+      done();
+    });
+  });
+
+
+  it("should get 403 on post of request_password_reset", (done) => {
+    request.post('http://localhost:8378/1/apps/invalid/request_password_reset', (err, httpResponse) => {
+      expect(httpResponse.statusCode).toBe(403);
+      done();
+    });
+  });
+
+  it("should get 403 on resendVerificationEmail", (done) => {
+    request('http://localhost:8378/1/apps/invalid/resend_verification_email', (err, httpResponse) => {
+      expect(httpResponse.statusCode).toBe(403);
+      done();
+    });
+  });
+});
diff --git a/src/Routers/PublicAPIRouter.js b/src/Routers/PublicAPIRouter.js
@@ -15,6 +15,10 @@ export class PublicAPIRouter extends PromiseRouter {
     const appId = req.params.appId;
     const config = Config.get(appId);
 
+    if(!config){
+      this.invalidRequest();
+    }
+
     if (!config.publicServerURL) {
       return this.missingPublicServerURL();
     }
@@ -40,6 +44,10 @@ export class PublicAPIRouter extends PromiseRouter {
     const appId = req.params.appId;
     const config = Config.get(appId);
 
+    if(!config){
+      this.invalidRequest();
+    }
+
     if (!config.publicServerURL) {
       return this.missingPublicServerURL();
     }
@@ -66,6 +74,11 @@ export class PublicAPIRouter extends PromiseRouter {
   changePassword(req) {
     return new Promise((resolve, reject) => {
       const config = Config.get(req.query.id);
+
+      if(!config){
+        this.invalidRequest();
+      }
+
       if (!config.publicServerURL) {
         return resolve({
           status: 404,
@@ -89,6 +102,10 @@ export class PublicAPIRouter extends PromiseRouter {
 
     const config = req.config;
 
+    if(!config){
+      this.invalidRequest();
+    }
+
     if (!config.publicServerURL) {
       return this.missingPublicServerURL();
     }
@@ -114,6 +131,10 @@ export class PublicAPIRouter extends PromiseRouter {
 
     const config = req.config;
 
+    if(!config){
+      this.invalidRequest();
+    }
+
     if (!config.publicServerURL) {
       return this.missingPublicServerURL();
     }
@@ -135,7 +156,7 @@ export class PublicAPIRouter extends PromiseRouter {
         location: `${config.passwordResetSuccessURL}?${params}`
       });
     }, (err) => {
-      const params = qs.stringify({username: username, token: token, id: config.applicationId, error:err, app:config.appName})
+      const params = qs.stringify({username: username, token: token, id: config.applicationId, error:err, app:config.appName});
       return Promise.resolve({
         status: 302,
         location: `${config.choosePasswordURL}?${params}`
@@ -171,6 +192,13 @@ export class PublicAPIRouter extends PromiseRouter {
     });
   }
 
+  invalidRequest() {
+    const error = new Error();
+    error.status = 403;
+    error.message = "unauthorized";
+    throw error;
+  }
+
   setConfig(req) {
     req.config = Config.get(req.params.appId);
     return Promise.resolve();
