remove expensive filewatcher for tensorboard (microsoft#18102)

amunger · web-flow · commit cf1f9b407537 · 2021-12-09T14:55:58.000-08:00
* remove the expensive file search for tensorboard prompt
diff --git a/src/client/tensorBoard/tensorBoardFileWatcher.ts b/src/client/tensorBoard/tensorBoardFileWatcher.ts
@@ -7,7 +7,6 @@ import { IExtensionSingleActivationService } from '../activation/types';
 import { IWorkspaceService } from '../common/application/types';
 import { NativeTensorBoard } from '../common/experiments/groups';
 import { IDisposableRegistry, IExperimentService } from '../common/types';
-import { traceError } from '../logging';
 import { TensorBoardEntrypointTrigger } from './constants';
 import { TensorBoardPrompt } from './tensorBoardPrompt';
 
@@ -40,10 +39,6 @@ export class TensorBoardFileWatcher implements IExtensionSingleActivationService
             return;
         }
 
-        // Look for pre-existing tfevent files, as the file watchers will only pick up files
-        // created or changed after they have been registered and hooked up. Just one will do.
-        await this.promptIfWorkspaceHasPreexistingFiles();
-
         // If the user creates or changes tfevent files, listen for those too
         for (const folder of folders) {
             this.createFileSystemWatcher(folder);
@@ -55,22 +50,6 @@ export class TensorBoardFileWatcher implements IExtensionSingleActivationService
         );
     }
 
-    private async promptIfWorkspaceHasPreexistingFiles() {
-        try {
-            for (const pattern of this.globPatterns) {
-                const matches = await this.workspaceService.findFiles(pattern, undefined, 1);
-                if (matches.length > 0) {
-                    await this.tensorBoardPrompt.showNativeTensorBoardPrompt(TensorBoardEntrypointTrigger.tfeventfiles);
-                    return;
-                }
-            }
-        } catch (e) {
-            traceError(
-                `Failed to prompt to launch TensorBoard session based on preexisting tfevent files in workspace: ${e}`,
-            );
-        }
-    }
-
     private async updateFileSystemWatchers(event: WorkspaceFoldersChangeEvent) {
         for (const added of event.added) {
             this.createFileSystemWatcher(added);
diff --git a/src/test/tensorBoard/tensorBoardFileWatcher.test.ts b/src/test/tensorBoard/tensorBoardFileWatcher.test.ts
@@ -52,39 +52,6 @@ suite('TensorBoard file system watcher', async () => {
         }
     });
 
-    test('Preexisting tfeventfile in workspace root results in prompt being shown', async () => {
-        await createFiles(currentDirectory);
-        await configureStubsAndActivate();
-        assert.ok(showNativeTensorBoardPrompt.called);
-    });
-
-    test('Preexisting tfeventfile one directory down results in prompt being shown', async () => {
-        const dir1 = path.join(currentDirectory, '1');
-        await createFiles(dir1);
-        await configureStubsAndActivate();
-        assert.ok(showNativeTensorBoardPrompt.called);
-    });
-
-    test('Preexisting tfeventfile two directories down results in prompt being called', async () => {
-        const dir2 = path.join(currentDirectory, '1', '2');
-        await createFiles(dir2);
-        await configureStubsAndActivate();
-        assert.ok(showNativeTensorBoardPrompt.called);
-    });
-
-    test('Preexisting tfeventfile three directories down does not result in prompt being called', async () => {
-        const dir3 = path.join(currentDirectory, '1', '2', '3');
-        await createFiles(dir3);
-        await configureStubsAndActivate();
-        assert.ok(showNativeTensorBoardPrompt.notCalled);
-    });
-
-    test('Creating tfeventfile in workspace root results in prompt being shown', async () => {
-        await configureStubsAndActivate();
-        await createFiles(currentDirectory);
-        await waitForCondition(async () => showNativeTensorBoardPrompt.called, 5000, 'Prompt not shown');
-    });
-
     test('Creating tfeventfile one directory down results in prompt being shown', async () => {
         const dir1 = path.join(currentDirectory, '1');
         await configureStubsAndActivate();
