Added recursion check in the getServiceResponse() method in the WebService class

pborissow · pborissow · commit b7cfe6f05a59 · 2023-02-08T19:20:33.000Z
git-svn-id: svn://192.168.0.80/JavaXT/javaxt-express@1485 2c7b0aa6-e0b2-3c4e-bb4a-8b65b6c465ff
diff --git a/src/javaxt/express/WebService.java b/src/javaxt/express/WebService.java
@@ -101,6 +101,9 @@ public ServiceResponse getServiceResponse(ServiceRequest request, Database datab
                     if (params.length>0){
                         if (ServiceRequest.class.isAssignableFrom(params[0])){
 
+
+                          //Check whether the method accepts a ServiceRequest
+                          //or ServiceRequest + Database as inputs
                             Object[] inputs = null;
                             if (params.length==1){
                                 inputs = new Object[]{request};
@@ -112,6 +115,23 @@ else if (params.length==2){
                             }
 
                             if (inputs!=null){
+
+
+                              //Ensure that we don't want to invoke this function!
+                              //For example, the caller might want to call
+                              //super.getServiceResponse(request, database);
+                              //If so, we would end up in a recursion causing a
+                              //stack overflow. Instead of calling getServiceResponse()
+                              //let's just flow down to the CRUD handlers below.
+                                StackTraceElement[] stackTrace = new Exception().getStackTrace();
+                                StackTraceElement el = stackTrace[1];
+                                if (m.getName().equals(el.getMethodName())){
+                                    break;
+                                }
+
+
+                              //If we're still here, call the requested method
+                              //and return the response
                                 try{
                                     m.setAccessible(true);
                                     return (ServiceResponse) m.invoke(this, inputs);
