CLOUDSTACK-3598: [Automation] NullPointerException observed while connecting agent

Vijayendra Bhamidipati · Sheng Yang · commit dfa612d1fe53 · 2013-07-18T08:55:57.000-07:00
Description:

    Fixing an NPE when setting resource count.
diff --git a/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java b/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java
@@ -98,7 +98,7 @@ public long getResourceCount(long ownerId, ResourceOwnerType ownerType, Resource
     @Override 
     public void setResourceCount(long ownerId, ResourceOwnerType ownerType, ResourceType type, long count) {
         ResourceCountVO resourceCountVO = findByOwnerAndType(ownerId, ownerType, type);
-        if (count != resourceCountVO.getCount()) {
+        if (resourceCountVO != null && count != resourceCountVO.getCount()) {
             resourceCountVO.setCount(count);
             update(resourceCountVO.getId(), resourceCountVO);
         }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ public long getResourceCount(long ownerId, ResourceOwnerType ownerType, Resource`
`98`	`98`	`@Override`
`99`	`99`	`public void setResourceCount(long ownerId, ResourceOwnerType ownerType, ResourceType type, long count) {`
`100`	`100`	`ResourceCountVO resourceCountVO = findByOwnerAndType(ownerId, ownerType, type);`
`101`		`- if (count != resourceCountVO.getCount()) {`
	`101`	`+ if (resourceCountVO != null && count != resourceCountVO.getCount()) {`
`102`	`102`	`resourceCountVO.setCount(count);`
`103`	`103`	`update(resourceCountVO.getId(), resourceCountVO);`
`104`	`104`	`}`