CLOUDSTACK-1514 : Unable to remove secondary ips though there are no PF rules associated with it

CloudStack-QA · Sateesh Chodapuneedi · commit cdae53a28914 · 2013-03-06T10:28:37.000+05:30
Fixed the search filter in PortForwardingRulesDaoImpl.java. Earlier we were
passing a wrong filter parameter "address" in listByDestIpAddr which doesn't
exist. Changed this to the right search criteria that uses dstIp as filter
parameter.

Signed-off-by: Venkata Swamybabu Budumuru &lt;venkataswamybabu.budumuru@citrix.com&gt;
Signed-off-by: Sateesh Chodapuneedi &lt;sateesh@apache.org&gt;
diff --git a/server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java b/server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java
@@ -155,7 +155,7 @@ public List<PortForwardingRuleVO> listByAccount(long accountId) {
     @Override
     public List<PortForwardingRuleVO> listByDestIpAddr(String ip4Address) {
         SearchCriteria<PortForwardingRuleVO> sc = AllFieldsSearch.create();
-        sc.setParameters("address", ip4Address);
+        sc.setParameters("dstIp", ip4Address);
         return listBy(sc);
     }
   

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ public List<PortForwardingRuleVO> listByAccount(long accountId) {`
`155`	`155`	`@Override`
`156`	`156`	`public List<PortForwardingRuleVO> listByDestIpAddr(String ip4Address) {`
`157`	`157`	`SearchCriteria<PortForwardingRuleVO> sc = AllFieldsSearch.create();`
`158`		`- sc.setParameters("address", ip4Address);`
	`158`	`+ sc.setParameters("dstIp", ip4Address);`
`159`	`159`	`return listBy(sc);`
`160`	`160`	`}`
`161`	`161`