Skip to content

Commit a4d0af2

Browse files
committed
Merge pull request apache#1000 from pritisarap12/CLOUDSTACK-9005-Modifying-tearDown-function
CLOUDSTACK-9005: Modifying tearDown functionModifying tearDown function to check if data volume is in detached state before deleting the volume * pr/1000: CLOUDSTACK-9005: Modifying tearDown function Signed-off-by: Remi Bergsma <github@remi.nl>
2 parents ad420bb + d793c7f commit a4d0af2

1 file changed

Lines changed: 17 additions & 16 deletions

File tree

test/integration/testpaths/testpath_snapshot_limits.py

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -123,24 +123,25 @@ def setUp(self):
123123
"Snapshots are not supported on %s" %
124124
self.hypervisor)
125125

126-
127126
def tearDown(self):
128127
try:
129-
data_volumes_list = Volume.list(
130-
self.userapiclient,
131-
id=self.data_volume_created.id,
132-
virtualmachineid=self.vm.id
133-
)
134-
status = validateList(data_volumes_list)
135-
self.assertEqual(
136-
status[0],
137-
PASS,
138-
"DATA Volume List Validation Failed")
139-
140-
self.vm.detach_volume(
141-
self.userapiclient,
142-
data_volumes_list[0]
143-
)
128+
if hasattr(self, "data_volume_created"):
129+
data_volumes_list = Volume.list(
130+
self.userapiclient,
131+
id=self.data_volume_created.id,
132+
virtualmachineid=self.vm.id
133+
)
134+
status = validateList(data_volumes_list)
135+
self.assertEqual(
136+
status[0],
137+
PASS,
138+
"DATA Volume List Validation Failed")
139+
140+
if data_volumes_list:
141+
self.vm.detach_volume(
142+
self.userapiclient,
143+
data_volumes_list[0]
144+
)
144145

145146
cleanup_resources(self.apiclient, self.cleanup)
146147
except Exception as e:

0 commit comments

Comments
 (0)