CLOUDSTACK-333: When Datacenter name in VCenter has spaces Primary Storage (VMFS) discovery will fail

Vijayendra Bhamidipati · Prasanna Santhanam · commit 8ced7da733f8 · 2012-12-13T22:43:59.000-08:00
Description:

    Missed encoding of URI when discovering ESX cluster in vCenter.

    Signed-off-by: Vijayendra Bhamidipati &lt;vijayendra.bhamidipati@citrix.com&gt;
diff --git a/server/src/com/cloud/storage/StorageManagerImpl.java b/server/src/com/cloud/storage/StorageManagerImpl.java
@@ -1281,7 +1281,7 @@ public StoragePoolVO createPool(CreateStoragePoolCmd cmd) throws ResourceInUseEx
         }
         URI uri = null;
         try {
-            uri = new URI(cmd.getUrl());
+            uri = new URI(UriUtils.encodeURIComponent(cmd.getUrl()));
             if (uri.getScheme() == null) {
                 throw new InvalidParameterValueException("scheme is null " + cmd.getUrl() + ", add nfs:// as a prefix");
             } else if (uri.getScheme().equalsIgnoreCase("nfs")) {

Original file line number	Diff line number	Diff line change
`@@ -1281,7 +1281,7 @@ public StoragePoolVO createPool(CreateStoragePoolCmd cmd) throws ResourceInUseEx`
`1281`	`1281`	`}`
`1282`	`1282`	`URI uri = null;`
`1283`	`1283`	`try {`
`1284`		`- uri = new URI(cmd.getUrl());`
	`1284`	`+ uri = new URI(UriUtils.encodeURIComponent(cmd.getUrl()));`
`1285`	`1285`	`if (uri.getScheme() == null) {`
`1286`	`1286`	`throw new InvalidParameterValueException("scheme is null " + cmd.getUrl() + ", add nfs:// as a prefix");`
`1287`	`1287`	`} else if (uri.getScheme().equalsIgnoreCase("nfs")) {`